You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2024/04/20 15:33:13 UTC
[PR] docs(intro): embed overview video into Intro document [superset]
hainenber opened a new pull request, #28163:
URL: https://github.com/apache/superset/pull/28163
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
docs(intro): embed overview video into Intro document
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Embed existing overview video about Superset into Intro document `intro.mdx` to help new users having faster understanding visually.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before
<img width="1346" alt="image" src="https://github.com/apache/superset/assets/41283691/e2a67aa6-be1c-4419-8a4b-2b6ca2147720">
After
<img width="1346" alt="image" src="https://github.com/apache/superset/assets/41283691/17d0e165-4cca-4728-bb4a-df73360bd2b5">
### TESTING INSTRUCTIONS
N/A
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
Closes #28162
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(intro): embed overview video into Intro document [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #28163:
URL: https://github.com/apache/superset/pull/28163#issuecomment-2075358031
> We might have to move the hosted, but I like the idea!
While I also share the sentiment of moving the video to some more reliable host, I think we can rely on it for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(intro): embed overview video into Intro document [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28163:
URL: https://github.com/apache/superset/pull/28163#issuecomment-2086621320
Nothing that needs to actually block the PR, in my book!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(intro): embed overview video into Intro document [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #28163:
URL: https://github.com/apache/superset/pull/28163#issuecomment-2085722998
Hello folks, is there anything not desired yet for merging in this PR? :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(intro): embed overview video into Intro document [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28163:
URL: https://github.com/apache/superset/pull/28163#issuecomment-2070855219
We might have to move the hosted, but I like the idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(intro): embed overview video into Intro document [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #28163:
URL: https://github.com/apache/superset/pull/28163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org