[GitHub] sijie commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #898: Bookies should prioritize recovery reads/writes
URL: https://github.com/apache/bookkeeper/pull/898#discussion_r158172798
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -725,6 +689,15 @@ private void readEntryInternal(final long ledgerId,
                 readBuilder = readBuilder.setFlag(ReadRequest.Flag.ENTRY_PIGGYBACK);
             }
 
+            // Only one flag can be set on the read requests
+            if (((short) flags & BookieProtocol.FLAG_DO_FENCING) == BookieProtocol.FLAG_DO_FENCING) {
+                readBuilder.setFlag(ReadRequest.Flag.FENCE_LEDGER);
+                checkArgument(masterKey != null);
 
 Review comment:
   dont do this. fail the callback with IncorrectParameterException

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services