You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/04/24 06:02:37 UTC
Review Request 66772: ATLAS-2597: Batch gremlin queries for Metric
related queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66772/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2597
https://issues.apache.org/jira/browse/ATLAS-2597
Repository: atlas
Description
-------
See JIRA ATLAS-2597
Diffs
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java bc05ed204
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java a20b0fd9e
Diff: https://reviews.apache.org/r/66772/diff/1/
Testing
-------
Tested with small cluster and configured batch size as 5 and 25, logs reported multiple query executions when the typeNames exceeded the batch size.
PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/304/
Thanks,
Apoorv Naik
Re: Review Request 66772: ATLAS-2597: Batch gremlin queries for Metric
related queries
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66772/#review202125
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Line 67 (original), 69 (patched)
<https://reviews.apache.org/r/66772/#comment283758>
batchSize ==> typesBatchSize
- Madhan Neethiraj
On April 24, 2018, 6:02 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66772/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 6:02 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2597
> https://issues.apache.org/jira/browse/ATLAS-2597
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA ATLAS-2597
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/services/MetricsService.java bc05ed204
> repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java a20b0fd9e
>
>
> Diff: https://reviews.apache.org/r/66772/diff/1/
>
>
> Testing
> -------
>
> Tested with small cluster and configured batch size as 5 and 25, logs reported multiple query executions when the typeNames exceeded the batch size.
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/304/
>
>
> Thanks,
>
> Apoorv Naik
>
>