You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/01/04 02:45:46 UTC

[GitHub] [submarine] jiwq commented on a change in pull request #141: SUBMARINE-330. Pack the k8s submitter libs into lib/submitter/k8s

jiwq commented on a change in pull request #141: SUBMARINE-330. Pack the k8s submitter libs into lib/submitter/k8s
URL: https://github.com/apache/submarine/pull/141#discussion_r363011550
 
 

 ##########
 File path: submarine-commons/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
 ##########
 @@ -337,8 +337,8 @@ public String getWebsocketMaxTextMessageSize() {
    * @param name the submitter's name
    * @return class name
    */
-  public String getSubmitterEntry(String name) {
-    return getStringValue(String.format(ConfVars.SUBMARINE_SUBMITTERS_ENTRY.getVarName(), name), "");
+  public String getSubmitterEntryClass(String name) {
 
 Review comment:
   Good catch, thanks for your review. Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org