[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725448
 
 

 ##########
 File path: tools/nxstyle.c
 ##########
 @@ -50,6 +50,45 @@
 
 #define LINE_SIZE    512
 
+#define FATAL(m)       message(FATAL, (m), 0, 0)
+#define FATALFL(m,s)   message(FATAL, (m), -1, -1)
+#define WARN(m, l, o)  message(WARN, (m), (l), (0))
+#define ERROR(m, l, o) message(ERROR, (m), (l), (0))
+#define INFO(m, l, o)  message(INFO, (m), (l), (0))
+
+/****************************************************************************
+ * Private types
+ ****************************************************************************/
+
+enum class_e {
+  INFO,
+  WARN,
+  ERROR,
+  FATAL
+};
+
+const char *class_text[] =
+{
+  "info",
+  "warning",
+  "error",
+  "fatal"
+};
+
+enum file_e {
+  unknown,
+  c_header,
+  c_source,
 
 Review comment:
   Enumeration values are always in upper case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services