You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "fabian4 (via GitHub)" <gi...@apache.org> on 2023/12/13 13:23:32 UTC
[PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
fabian4 opened a new pull request, #4641:
URL: https://github.com/apache/eventmesh/pull/4641
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4607.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] Documentation Needed for eventmesh-connector-rabbitmq (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#discussion_r1425441164
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README_CN.md:
##########
@@ -0,0 +1,39 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector：从 eventmesh 到 rabbitmq。
+
+1. 启动你的 rabbitmq 服务和 eventmesh-runtime。
+2. 启用 sinkConnector 并检查 `sink-config.yml`。
+3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
+ subject: TopicTest
+ idc: FT
+ env: PRD
+ group: rabbitmqSink
+ appId: 5031
+ userName: rabbitmqSinkUser
+ passWord: rabbitmqPassWord
+connectorConfig:
+ connectorName: rabbitmqSink
+ host: your.rabbitmq.server
+ port: 5672
+ username: coyrqpyz
+ passwd: passwd
+ virtualHost: coyrqpyz
+ exchangeType: TOPIC
+ # 使用内置的 exchangeName 或在连接到 rabbitmq 服务器后创建新的 exchangeName。
+ exchangeName: amq.topic
+ # 如果在连接之前不存在，rabbitmq 服务器将自动创建 routingKey 和 queueName。
+ routingKey: eventmesh
Review Comment:
The translation of 'rabbitmq 服务器' is not considered a good one.
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README_CN.md:
##########
@@ -0,0 +1,39 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector：从 eventmesh 到 rabbitmq。
+
+1. 启动你的 rabbitmq 服务和 eventmesh-runtime。
+2. 启用 sinkConnector 并检查 `sink-config.yml`。
+3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
+ subject: TopicTest
+ idc: FT
+ env: PRD
+ group: rabbitmqSink
+ appId: 5031
+ userName: rabbitmqSinkUser
+ passWord: rabbitmqPassWord
+connectorConfig:
+ connectorName: rabbitmqSink
+ host: your.rabbitmq.server
+ port: 5672
+ username: coyrqpyz
+ passwd: passwd
+ virtualHost: coyrqpyz
+ exchangeType: TOPIC
+ # 使用内置的 exchangeName 或在连接到 rabbitmq 服务器后创建新的 exchangeName。
+ exchangeName: amq.topic
+ # 如果在连接之前不存在，rabbitmq 服务器将自动创建 routingKey 和 queueName。
+ routingKey: eventmesh
Review Comment:
The translation of 'rabbitmq 服务器' is not considered as a good one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#discussion_r1426054645
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README.md:
##########
@@ -0,0 +1,38 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector: from eventmesh to rabbitmq.
+
+1. launch your rabbitmq server and eventmesh-runtime.
+2. enable sinkConnector and check `sink-config.yml`.
+3. send a message to eventmesh with the topic defined in `pubSubConfig.subject`
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
Review Comment:
Could this configuration value be changed to follow the format of your `your.rabbitmq.server` below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#discussion_r1425441164
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README_CN.md:
##########
@@ -0,0 +1,39 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector：从 eventmesh 到 rabbitmq。
+
+1. 启动你的 rabbitmq 服务和 eventmesh-runtime。
+2. 启用 sinkConnector 并检查 `sink-config.yml`。
+3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
+ subject: TopicTest
+ idc: FT
+ env: PRD
+ group: rabbitmqSink
+ appId: 5031
+ userName: rabbitmqSinkUser
+ passWord: rabbitmqPassWord
+connectorConfig:
+ connectorName: rabbitmqSink
+ host: your.rabbitmq.server
+ port: 5672
+ username: coyrqpyz
+ passwd: passwd
+ virtualHost: coyrqpyz
+ exchangeType: TOPIC
+ # 使用内置的 exchangeName 或在连接到 rabbitmq 服务器后创建新的 exchangeName。
+ exchangeName: amq.topic
+ # 如果在连接之前不存在，rabbitmq 服务器将自动创建 routingKey 和 queueName。
+ routingKey: eventmesh
Review Comment:
"rabbitmq 服务器" is a bad translation.
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README_CN.md:
##########
@@ -0,0 +1,39 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector：从 eventmesh 到 rabbitmq。
+
+1. 启动你的 rabbitmq 服务和 eventmesh-runtime。
+2. 启用 sinkConnector 并检查 `sink-config.yml`。
+3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
+ subject: TopicTest
+ idc: FT
+ env: PRD
+ group: rabbitmqSink
+ appId: 5031
+ userName: rabbitmqSinkUser
+ passWord: rabbitmqPassWord
+connectorConfig:
+ connectorName: rabbitmqSink
+ host: your.rabbitmq.server
+ port: 5672
+ username: coyrqpyz
+ passwd: passwd
+ virtualHost: coyrqpyz
+ exchangeType: TOPIC
+ # 使用内置的 exchangeName 或在连接到 rabbitmq 服务器后创建新的 exchangeName。
+ exchangeName: amq.topic
+ # 如果在连接之前不存在，rabbitmq 服务器将自动创建 routingKey 和 queueName。
+ routingKey: eventmesh
Review Comment:
"rabbitmq 服务器" is a bad translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
Posted by "fabian4 (via GitHub)" <gi...@apache.org>.
fabian4 commented on code in PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#discussion_r1426130972
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README_CN.md:
##########
@@ -0,0 +1,39 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector：从 eventmesh 到 rabbitmq。
+
+1. 启动你的 rabbitmq 服务和 eventmesh-runtime。
+2. 启用 sinkConnector 并检查 `sink-config.yml`。
+3. 向 eventmesh 发送带有在 `pubSubConfig.subject` 中定义的主题消息。
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
+ subject: TopicTest
+ idc: FT
+ env: PRD
+ group: rabbitmqSink
+ appId: 5031
+ userName: rabbitmqSinkUser
+ passWord: rabbitmqPassWord
+connectorConfig:
+ connectorName: rabbitmqSink
+ host: your.rabbitmq.server
+ port: 5672
+ username: coyrqpyz
+ passwd: passwd
+ virtualHost: coyrqpyz
+ exchangeType: TOPIC
+ # 使用内置的 exchangeName 或在连接到 rabbitmq 服务器后创建新的 exchangeName。
+ exchangeName: amq.topic
+ # 如果在连接之前不存在，rabbitmq 服务器将自动创建 routingKey 和 queueName。
+ routingKey: eventmesh
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] Documentation Needed for eventmesh-connector-rabbitmq (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#issuecomment-1855116038
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`87ed40d`)](https://app.codecov.io/gh/apache/eventmesh/commit/87ed40d99916cef2e00a8f9ecff4c315b62fdfdd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.38% compared to head [(`419ed4a`)](https://app.codecov.io/gh/apache/eventmesh/pull/4641?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.38%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4641 +/- ##
============================================
- Coverage 17.38% 17.38% -0.01%
- Complexity 1757 1758 +1
============================================
Files 797 797
Lines 29776 29771 -5
Branches 2573 2571 -2
============================================
- Hits 5177 5175 -2
+ Misses 24121 24117 -4
- Partials 478 479 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4641?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4607] feat: Add doc for eventmesh-connector-rabbitmq (eventmesh)
Posted by "fabian4 (via GitHub)" <gi...@apache.org>.
fabian4 commented on code in PR #4641:
URL: https://github.com/apache/eventmesh/pull/4641#discussion_r1426131104
##########
eventmesh-connectors/eventmesh-connector-rabbitmq/README.md:
##########
@@ -0,0 +1,38 @@
+# eventmesh-connector-rabbitmq
+
+## RabbitMQSinkConnector: from eventmesh to rabbitmq.
+
+1. launch your rabbitmq server and eventmesh-runtime.
+2. enable sinkConnector and check `sink-config.yml`.
+3. send a message to eventmesh with the topic defined in `pubSubConfig.subject`
+```yaml
+pubSubConfig:
+ meshAddress: 127.0.0.1:10000
Review Comment:
Just fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org