You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 12:31:33 UTC

[GitHub] [airflow] potiuk commented on pull request #28611: Fix scheduler-deployment.yaml

potiuk commented on PR #28611:
URL: https://github.com/apache/airflow/pull/28611#issuecomment-1373567598

   Glad it helped @dharmendrakariya !
   
   cc: @jedcunningham -> do you think we should:
   
   a) fix the issue with persistence + git sync in our chart
   b) warn the users when they use persistence + git sync
   c) disallow the "persistence + git sync" combination
   
   ?
   
   As you might well guess, my personal preference is c) -> I **REALLY** think git sync + persistence is "never-needed" and "widely misleading" combo - that does not do what the users think it does and, in some cases (like above), does not even really work in our chart. I know you had some reservations for it in the past, but even after quite some time passed, I failed to see where this combo would be useful, and I would rather prevent or at the very least strongly warn our users when they use it. If we prevent this - we will have less of a matrix of possible cases to handle in the chart BTW.
   
   Or maybe there is another way (for example fixing the problem found by @dharmendrakariya :)? WDYT @jedcunningham ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org