You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Valentyn Tymofieiev <va...@google.com> on 2019/07/19 21:52:31 UTC
An update on Python postcommit tests
We have split Python 2, Python 3.5 - 3.7 postcommit test suites into
individual Jenkins jobs that can be triggered with a phrase of their own.
"Run Python PostCommit" no longer triggers anything.
Use following trigger phrases to start or re-run postcommits on your PR:
Run Python 2 PostCommit
Run Python 3.5 PostCommit
Run Python 3.6 PostCommit
Run Python 3.7 PostCommit
Trigger phrases are case-insensitive. Also, at the bottom of the PR
template there is a glossary of all jobs and trigger phrases.
Thanks,
Valentyn
Re: An update on Python postcommit tests
Posted by Tanay Tummalapalli <tt...@gmail.com>.
Oh. That wouldn't be ideal.
Thank You for sharing!
Regards,
-Tanay
On Sun, Jul 21, 2019 at 2:20 AM Valentyn Tymofieiev <va...@google.com>
wrote:
> The GitHub pull request builder plugin, which we currently use, allow only
> one trigger phrase per Jenkins job [1].
>
> We could have another job that runs all 4 postcommits, but it would appear
> on a PR as a different job, separate from per-minor-version jobs.
>
> [1]
> https://github.com/jenkinsci/ghprb-plugin/blob/f4eb4bc1ee3fd53284d3889c69558c9f36d5379d/src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java#L124
>
> On Sat, Jul 20, 2019 at 12:52 PM Tanay Tummalapalli <tt...@gmail.com>
> wrote:
>
>> Thank You! This will make the testing cycle much faster for contributors.
>>
>> I'm curious; why not still have the original "Run Python PostCommit"
>> trigger phrase?
>> It would be easier to run all the four tests with it when needed.
>>
>> Regards,
>> - Tanay
>>
>>>
Re: An update on Python postcommit tests
Posted by Valentyn Tymofieiev <va...@google.com>.
The GitHub pull request builder plugin, which we currently use, allow only
one trigger phrase per Jenkins job [1].
We could have another job that runs all 4 postcommits, but it would appear
on a PR as a different job, separate from per-minor-version jobs.
[1]
https://github.com/jenkinsci/ghprb-plugin/blob/f4eb4bc1ee3fd53284d3889c69558c9f36d5379d/src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java#L124
On Sat, Jul 20, 2019 at 12:52 PM Tanay Tummalapalli <tt...@gmail.com>
wrote:
> Thank You! This will make the testing cycle much faster for contributors.
>
> I'm curious; why not still have the original "Run Python PostCommit"
> trigger phrase?
> It would be easier to run all the four tests with it when needed.
>
> Regards,
> - Tanay
>
>>
Re: An update on Python postcommit tests
Posted by Tanay Tummalapalli <tt...@gmail.com>.
Thank You! This will make the testing cycle much faster for contributors.
I'm curious; why not still have the original "Run Python PostCommit"
trigger phrase?
It would be easier to run all the four tests with it when needed.
Regards,
- Tanay
>
Re: An update on Python postcommit tests
Posted by Ahmet Altay <al...@google.com>.
Thank you! Hopefully this will improve the state of testing.
On Fri, Jul 19, 2019 at 2:53 PM Valentyn Tymofieiev <va...@google.com>
wrote:
> We have split Python 2, Python 3.5 - 3.7 postcommit test suites into
> individual Jenkins jobs that can be triggered with a phrase of their own.
>
> "Run Python PostCommit" no longer triggers anything.
>
> Use following trigger phrases to start or re-run postcommits on your PR:
>
> Run Python 2 PostCommit
> Run Python 3.5 PostCommit
> Run Python 3.6 PostCommit
> Run Python 3.7 PostCommit
>
> Trigger phrases are case-insensitive. Also, at the bottom of the PR
> template there is a glossary of all jobs and trigger phrases.
>
> Thanks,
> Valentyn
>