[GitHub] [kafka] mumrah commented on a diff in pull request #12318: MINOR: Support --release in FeatureCommand

[GitBox <gi...@apache.org>]

mumrah commented on code in PR #12318:
URL: https://github.com/apache/kafka/pull/12318#discussion_r920433990


##########
core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala:
##########
@@ -107,4 +116,17 @@ class FeatureCommandTest extends BaseRequestTest {
       assertTrue(downgradeDescribeOutput.contains(expectedOutput))
     }
   }
+
+  @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+  @ValueSource(strings = Array("kraft"))
+  def testUpdateFeatureByReleaseVersion(quorum: String): Unit = {
+    val initialDescribeOutput = TestUtils.grabConsoleOutput(FeatureCommand.mainNoExit(Array("--bootstrap-server", bootstrapServers(), "describe")))
+    assertTrue(initialDescribeOutput.contains("Feature: metadata.version\tSupportedMinVersion: 1\tSupportedMaxVersion: 7\tFinalizedVersionLevel: 1"))
+
+    FeatureCommand.mainNoExit(Array("--bootstrap-server", bootstrapServers(), "upgrade", "--release", IBP_3_3_IV3.version()))

Review Comment:
   Can we add a negative test case where `--release` and `--feature` are given?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org