You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by becketqin <gi...@git.apache.org> on 2015/08/13 03:28:58 UTC

[GitHub] kafka pull request: KAFKA-2389: remove commit type from new consum...

GitHub user becketqin opened a pull request:

    https://github.com/apache/kafka/pull/134

    KAFKA-2389: remove commit type from new consumer.

    A shot to remove commit type from new consumer. The coordinator constructor takes a default offset commit callback mainly for testing purpose.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/becketqin/kafka KAFKA-2389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 5f332efa6c690fad730278283d8c419c6a223a8e
Author: Jiangjie Qin <be...@gmail.com>
Date:   2015-08-11T19:41:15Z

    KAFKA-2389: Remove commit type from commit()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-2389: remove commit type from new consum...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---