You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/23 11:30:39 UTC
[GitHub] [incubator-nuttx] ChaochaoCui opened a new pull request #2385: add simple wm8994 codec driver
ChaochaoCui opened a new pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ChaochaoCui commented on a change in pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
ChaochaoCui commented on a change in pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385#discussion_r528672242
##########
File path: drivers/audio/wm8994.h
##########
@@ -0,0 +1,1658 @@
+/***************************************************************************************************
+ * drivers/audio/wm8994.h
+ *
+ * Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ChaochaoCui closed pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
ChaochaoCui closed pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385#discussion_r528641949
##########
File path: include/nuttx/audio/wm8994.h
##########
@@ -0,0 +1,277 @@
+/****************************************************************************
+ * include/nuttx/audio/wm8994.h
+ *
+ * Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
change to apache license too
##########
File path: drivers/audio/wm8994.c
##########
@@ -0,0 +1,2033 @@
+/***********************************************************************************
+ * drivers/audio/wm8994.c
+ *
+ * Audio device driver for Wolfson Microelectronics WM8994 Audio codec.
+ *
+ * Copyright (C) 2014, 2016-2019 Gregory Nutt. All rights reserved.
Review comment:
change to apache license
##########
File path: drivers/audio/wm8994_debug.c
##########
@@ -0,0 +1,565 @@
+/*****************************************************************************************
+ * drivers/audio/wm8994_debug.c
+ *
+ * Audio device driver for Wolfson Microelectronics WM8904 Audio codec.
+ *
+ * Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
change to apache license
##########
File path: boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c
##########
@@ -0,0 +1,231 @@
+/****************************************************************************
+ * boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c
+ *
+ * Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
need change apache license
##########
File path: drivers/audio/wm8994.h
##########
@@ -0,0 +1,1658 @@
+/***************************************************************************************************
+ * drivers/audio/wm8994.h
+ *
+ * Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
change to apache license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385#issuecomment-732111883
@ChaochaoCui could you fix the warning:
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/drivers/audio/wm8994.h:145:62: warning: Wrong column position of comment right of code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385#issuecomment-732143361
@ChaochaoCui don't need close the PR. you can update the PR locally by:
git push -f origin stm32f746g-disco_audio
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ChaochaoCui closed pull request #2385: add simple wm8994 codec driver
Posted by GitBox <gi...@apache.org>.
ChaochaoCui closed pull request #2385:
URL: https://github.com/apache/incubator-nuttx/pull/2385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org