You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brahma Reddy Battula (JIRA)" <ji...@apache.org> on 2012/05/25 10:58:22 UTC
[jira] [Created] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Brahma Reddy Battula created HADOOP-8437:
--------------------------------------------
Summary: getLocalPathForWrite is not throwing any expection for invalid paths
Key: HADOOP-8437
URL: https://issues.apache.org/jira/browse/HADOOP-8437
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 2.0.1-alpha
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462640#comment-13462640 ]
Hadoop QA commented on HADOOP-8437:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546490/HADOOP-8437_1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestLocalDirAllocator
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1515//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1515//console
This message is automatically generated.
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284878#comment-13284878 ]
Brahma Reddy Battula commented on HADOOP-8437:
----------------------------------------------
Following testcases failing because someother(timedout) reason not because of this fix..
{noformat}
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
{noformat}
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.1-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8437:
----------------------------
Status: Open (was: Patch Available)
Canceling patch until the few superficial comments are addressed.
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462669#comment-13462669 ]
Harsh J commented on HADOOP-8437:
---------------------------------
Doesn't seem like the logic is working (and hence the test failure), can you recheck the patch please Brahma? I'm not sure what we're missing :)
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8437:
----------------------------
Fix Version/s: (was: 2.0.2-alpha)
(was: 3.0.0)
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284480#comment-13284480 ]
Hadoop QA commented on HADOOP-8437:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529963/HADOOP-8437.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1044//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1044//console
This message is automatically generated.
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.1-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462631#comment-13462631 ]
Brahma Reddy Battula commented on HADOOP-8437:
----------------------------------------------
Hi Harsh,
Thanks a lot for reviewing the patch..I updated patch..
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470755#comment-13470755 ]
Harsh J commented on HADOOP-8437:
---------------------------------
Would permissions not work?
I had tried the special char approach on your patch earlier but Linux supports almost everything we could use as a reasonable test. If permission tweaks are not gonna work, I'm fine with the 256 length test, with a comment added along that this depends on the FS in use to fail and may pass on some FS.
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brahma Reddy Battula updated HADOOP-8437:
-----------------------------------------
Status: Patch Available (was: Open)
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470076#comment-13470076 ]
Brahma Reddy Battula commented on HADOOP-8437:
----------------------------------------------
Hi Harsh,
do u have any suggestions on this apart from permissions..? or following will be okie.
{code}
for (int i = 0; i < 256; i++) {
+ invalidPath.append("A");
+ }
{code}
I tried with special chars which are not supported by OS..
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283223#comment-13283223 ]
Brahma Reddy Battula commented on HADOOP-8437:
----------------------------------------------
In earlier version
{code}
localDirs = dirs.toArray(new String[dirs.size()]);
dirDF = dfList.toArray(new DF[dirs.size()]);
savedLocalDirs = newLocalDirs;
if (0 == dirs.size()) {
throw new IOException("No dirs to select.Total dirs size is 0");
}
// randomize the first disk picked in the round-robin selection
dirNumLastAccessed = dirIndexRandomizer.nextInt(dirs.size());
dirNumLastAccessedforKnownSize = dirNumLastAccessed;
{code}
Here it is throwing IOException saying that No dirs to select.Total dirs size is 0
But in brnach2 and trunk...code is like follwoing..
{code}
localDirs = dirs.toArray(new String[dirs.size()]);
dirDF = dfList.toArray(new DF[dirs.size()]);
savedLocalDirs = newLocalDirs;
// randomize the first disk picked in the round-robin selection
dirNumLastAccessed = dirIndexRandomizer.nextInt(dirs.size());
{code}
Here follwoing check is removed..
{code}
if (0 == dirs.size()) {
throw new IOException("No dirs to select.Total dirs size is 0");
}
{code}
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.1-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brahma Reddy Battula updated HADOOP-8437:
-----------------------------------------
Fix Version/s: 3.0.0
2.0.1-alpha
Status: Patch Available (was: Open)
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.1-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461455#comment-13461455 ]
Harsh J commented on HADOOP-8437:
---------------------------------
Hi Brahma,
Couple of comments:
{code}
+ if (0 == dirs.size()) {
{code}
I feel this check can happen slightly more earlier as the hunk itself seems to suggest that dirs is being utilized before we come to this new check.
{code}
+ throw new IOException("No dirs to select.Total dirs size is 0");
{code}
Please space the two sentences (general rule: Always a space after a punctuation mark, never before.)
{code}
+ for (int i = 0; i < 256; i++) {
+ invalidPath.append("A");
+ }
{code}
Seems excessive to do this. Just declare a constant string? :-)
{code}
fail("not throwing the exception");
{code}
Lets describe failure strings better since it is a specific test we're carrying out/expecting a failure from: "An exception should have been thrown when an invalid directory is used."
Thanks!
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brahma Reddy Battula updated HADOOP-8437:
-----------------------------------------
Attachment: HADOOP-8437.patch
attaching Patch
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.1-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brahma Reddy Battula updated HADOOP-8437:
-----------------------------------------
Attachment: HADOOP-8437_1.patch
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not
throwing any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462682#comment-13462682 ]
Harsh J commented on HADOOP-8437:
---------------------------------
Ok so its cause of my earlier comment:
{code}
+ for (int i = 0; i < 256; i++) {
+ invalidPath.append("A");
+ }
{code}
This creates a condition where the filename request is > max allowed filename length on some FS-es. Since thats not a nice way to do it (it may begin 'passing' on some FSes), lets instead play with permissions or something?
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing
any expection for invalid paths
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8437:
----------------------------
Status: Open (was: Patch Available)
> getLocalPathForWrite is not throwing any expection for invalid paths
> --------------------------------------------------------------------
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437_1.patch, HADOOP-8437.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira