[GitHub] [incubator-hudi] ovj commented on a change in pull request #583: Replacing Apache commons-lang3 object serializer with Kryo serializer

[GitBox <gi...@apache.org>]

ovj commented on a change in pull request #583: Replacing Apache commons-lang3 object serializer with Kryo serializer
URL: https://github.com/apache/incubator-hudi/pull/583#discussion_r266579375
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/util/SerializationUtils.java
 ##########
 @@ -166,6 +71,33 @@ public static void serialize(final Serializable obj, final OutputStream outputSt
     if (objectData == null) {
       throw new IllegalArgumentException("The byte[] must not be null");
     }
-    return deserialize(new ByteArrayInputStream(objectData));
+    return (T) serializerRef.get().deserialize(objectData);
+  }
+
+  private static class KryoSerializerInstance implements Serializable {
+    public static final int KRYO_SERIALIZER_BUFFER_SIZE = 1048576;
 
 Review comment:
   Yes this is an initial buffer size. if we try to write larger object then it will auto grow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services