You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 05:09:50 UTC
[I] why hudi clean service actually retain CLEAN_RETAIN_COMMITS + 1 [hudi]
hudi-bot opened a new issue, #15316:
URL: https://github.com/apache/hudi/issues/15316
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-4537
- Type: Wish
---
## Comments
04/Aug/22 09:16;flashJd;CleanPlanner.java:
if (policy == HoodieCleaningPolicy.KEEP_LATEST_COMMITS) {
// Dont delete the latest commit and {color:#FF0000}also the last commit before the earliest commit we{color}
{color:#FF0000} // are retaining{color}
// The window of commit retain == max query run time. So a query could be running which
// still
// uses this file.
if (fileCommitTime.equals(lastVersion) || {color:#FF0000}(fileCommitTime.equals(lastVersionBeforeEarliestCommitToRetain)){color}) {
// move on to the next file
continue;
};;;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] why hudi clean service actually retain CLEAN_RETAIN_COMMITS + 1 [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 closed issue #15316: why hudi clean service actually retain CLEAN_RETAIN_COMMITS + 1
URL: https://github.com/apache/hudi/issues/15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] why hudi clean service actually retain CLEAN_RETAIN_COMMITS + 1 [hudi]
Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on issue #15316:
URL: https://github.com/apache/hudi/issues/15316#issuecomment-5326193028
This issue was reviewed as part of the JIRA-migrated backlog triage and is being closed as stale.
The description is empty and the title is a question rather than a request - *"why hudi clean service actually retain CLEAN_RETAIN_COMMITS + 1"* - filed as a Wish. It does not say whether the off-by-one should be treated as a bug, a documentation gap, or expected behaviour. The JIRA last moved 2022-08-09.
No commit or PR carries HUDI-4537, and the semantics do not appear to have changed by release-1.2.0. Retaining one extra commit is intentional: the cleaner has to keep the commit that the last retained commit's file slices depend on for reads to stay consistent.
Closing. If the documented meaning of `hoodie.cleaner.commits.retained` should be clarified, that is a small docs issue worth filing against the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org