You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/10/23 21:09:37 UTC

[GitHub] [phoenix] priyankporwal commented on a change in pull request #605: PHOENIX-5540 Full row index write at the last write phase for immutab…

priyankporwal commented on a change in pull request #605: PHOENIX-5540 Full row index write at the last write phase for immutab…
URL: https://github.com/apache/phoenix/pull/605#discussion_r338279923
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
 ##########
 @@ -417,6 +422,58 @@ public void testGlobalImmutableIndexDelete() throws Exception {
         }
     }
 
+    @Test
+    public void testGlobalImmutableIndexFullWriteOnLast() throws Exception {
 
 Review comment:
   Nit: This test only validates phase1 that it does not write the full row and only unverified. The test name should probably be something like "testGlobalImmutableIndexUnverifiedOnlyInPhase1" 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services