You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2020/12/07 19:35:07 UTC

Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.

Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Jim Jagielski <ji...@jaguNET.com>.
Just a FYI that I've been hacking on

    https://github.com/jimjag/beanshell2

which is merge of 2.0b6 and beanshell2.

> On Dec 7, 2020, at 8:06 PM, Peter Kovacs <pe...@Apache.org> wrote:
> 
> 
> On 07.12.20 21:56, Mechtilde wrote:
>> Hello Jim
>> 
>> Am 07.12.20 um 20:35 schrieb Jim Jagielski:
>>> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.
>> I built it with the system version of Debian 10 bsh 2.0b4-19. and this
>> part works.
> 
> This is odd. I bumbed the build.xml file from 1.5 to 1.7 according to the Errormessage.
> 
> Now I have 1 error:
> 
> /home/legine/workspace/AOO/github/main/beanshell/unxlngx6.pro/misc/build/BeanShell-2.0b6/src/bsh/util/AWTConsole.java:217: error: cannot find symbol
> ((java.awt.peer.TextComponentPeer)getPeer()).setCaretPosition(
> 
> and 96 warnings
> 
> A lot look like: warning: [deprecation]
> 
> So how could Debian build them if they use an older Code?
> 
> However it looks like this code queen needs some serious attention. (Java 14 throws deprecation for 1.7)
> 
> I check tomorrow, and look into fixing the code.
> 
>> 
>> Now the build hangs with hsqldb
>> 
>> there I have no success to change to the system version of hsqldb 1.8.0
>>> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
>> kind regards
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Peter Kovacs <pe...@apache.org>.
On 07.12.20 21:56, Mechtilde wrote:
> Hello Jim
>
> Am 07.12.20 um 20:35 schrieb Jim Jagielski:
>> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.
> I built it with the system version of Debian 10 bsh 2.0b4-19. and this
> part works.

This is odd. I bumbed the build.xml file from 1.5 to 1.7 according to 
the Errormessage.

Now I have 1 error:

/home/legine/workspace/AOO/github/main/beanshell/unxlngx6.pro/misc/build/BeanShell-2.0b6/src/bsh/util/AWTConsole.java:217: 
error: cannot find symbol
((java.awt.peer.TextComponentPeer)getPeer()).setCaretPosition(

and 96 warnings

A lot look like: warning: [deprecation]

So how could Debian build them if they use an older Code?

However it looks like this code queen needs some serious attention. 
(Java 14 throws deprecation for 1.7)

I check tomorrow, and look into fixing the code.

>
> Now the build hangs with hsqldb
>
> there I have no success to change to the system version of hsqldb 1.8.0
>> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
> kind regards
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Peter Kovacs <pe...@apache.org>.
On 07.12.20 23:34, Dave Fisher wrote:
>
> Sent from my iPhone
>
>> On Dec 7, 2020, at 2:08 PM, Peter Kovacs <Pe...@apache.org> wrote:
>>
>> 
>>> On 07.12.20 21:56, Mechtilde wrote:
>>> Hello Jim
>>>
>>>> Am 07.12.20 um 20:35 schrieb Jim Jagielski:
>>>> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.
>>> I built it with the system version of Debian 10 bsh 2.0b4-19. and this
>>> part works.
>> Ok.
>>> Now the build hangs with hsqldb
>>>
>>> there I have no success to change to the system version of hsqldb 1.8.0
>> Well, the issue is that Java has removed a insecure System API, which HSQLDB uses:
>>
>>    cannot find symbol  System.runFinalizersOnExit(true);
>>
>> All resources I found are saying you should not use this API. So maybe you can remove the code. Maybe not because the Programmer has been super smart.
> This link might help.
>
> https://help.semmle.com/wiki/plugins/servlet/mobile?contentId=29393456#content/view/29393456
>
> We’ll need to look at finalize methods in the Java we use.

I researched in the Discussion Archives of hsqldb. I found [1] which 
states the use is only conveniance and can commented out. I am trying a 
build with removed lines. If it works out we could place 2 patches.

[1] 
https://sourceforge.net/p/hsqldb/discussion/73674/thread/82623c95/?limit=25#fc78/e01b

>
>> Maybe we can try a later version and it works?! Maybe 1.9 works?
>>
>> - I do not know. But this one is a real action point. And thgus I started the discussion. Figuring out what we do now is here imho the most vital part.
>>
>>>> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
>>> kind regards
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Dave Fisher <wa...@apache.org>.

Sent from my iPhone

> On Dec 7, 2020, at 2:08 PM, Peter Kovacs <Pe...@apache.org> wrote:
> 
> 
>> On 07.12.20 21:56, Mechtilde wrote:
>> Hello Jim
>> 
>>> Am 07.12.20 um 20:35 schrieb Jim Jagielski:
>>> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.
>> I built it with the system version of Debian 10 bsh 2.0b4-19. and this
>> part works.
> Ok.
>> 
>> Now the build hangs with hsqldb
>> 
>> there I have no success to change to the system version of hsqldb 1.8.0
> 
> Well, the issue is that Java has removed a insecure System API, which HSQLDB uses:
> 
>   cannot find symbol  System.runFinalizersOnExit(true);
> 
> All resources I found are saying you should not use this API. So maybe you can remove the code. Maybe not because the Programmer has been super smart.

This link might help.

https://help.semmle.com/wiki/plugins/servlet/mobile?contentId=29393456#content/view/29393456

We’ll need to look at finalize methods in the Java we use.

> 
> Maybe we can try a later version and it works?! Maybe 1.9 works?
> 
> - I do not know. But this one is a real action point. And thgus I started the discussion. Figuring out what we do now is here imho the most vital part.
> 
>>> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
>> kind regards
>> 

Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Peter Kovacs <pe...@apache.org>.
On 07.12.20 21:56, Mechtilde wrote:
> Hello Jim
>
> Am 07.12.20 um 20:35 schrieb Jim Jagielski:
>> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.
> I built it with the system version of Debian 10 bsh 2.0b4-19. and this
> part works.
Ok.
>
> Now the build hangs with hsqldb
>
> there I have no success to change to the system version of hsqldb 1.8.0

Well, the issue is that Java has removed a insecure System API, which 
HSQLDB uses:

    cannot find symbol  System.runFinalizersOnExit(true);

All resources I found are saying you should not use this API. So maybe 
you can remove the code. Maybe not because the Programmer has been super 
smart.

Maybe we can try a later version and it works?! Maybe 1.9 works?

- I do not know. But this one is a real action point. And thgus I 
started the discussion. Figuring out what we do now is here imho the 
most vital part.

>> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.
> kind regards
>

Re: Beanshell (Re: Source and target of Java version (Was: Review of PR 109))

Posted by Mechtilde <oo...@mechtilde.de>.
Hello Jim

Am 07.12.20 um 20:35 schrieb Jim Jagielski:
> There appears to be quite a large change in beanshell from 2.0b6 and what is currently HEAD of master.

I built it with the system version of Debian 10 bsh 2.0b4-19. and this
part works.

Now the build hangs with hsqldb

there I have no success to change to the system version of hsqldb 1.8.0
> 
> Any interest in looking into getting beanshell into some more stable situation... It looks like it's been majorly refactored.

kind regards

-- 
Mechtilde Stehmann
## Apache OpenOffice
## Freie Office Suite für Linux, MacOSX, Windows und OS/2
## Debian Developer
## PGP encryption welcome
## F0E3 7F3D C87A 4998 2899  39E7 F287 7BBA 141A AD7F