[GitHub] [spark] srielau commented on pull request #37520: [SPARK-40098][SQL] Format error messages in the Thrift Server

[GitBox <gi...@apache.org>]

srielau commented on PR #37520:
URL: https://github.com/apache/spark/pull/37520#issuecomment-1274348629

   Please stick with 1. we should not change values based on formatting of the error.
   
   Sent from my iPhone
   
   On Aug 16, 2022, at 1:38 PM, Maxim Gekk ***@***.***> wrote:
   
   
   
   For Json format output, I am ok with 0-based or 1-based. Either way makes sense...
   
   If we assume that the messages in the JSON format will be parsed machinery, it would be more natural to begin the indexes from 0, IMHO.
   
   —
   Reply to this email directly, view it on GitHub<https://github.com/apache/spark/pull/37520#issuecomment-1217135789>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA22CFGO7PHMRABGOZVH6M3VZP34PANCNFSM56RPFPYA>.
   You are receiving this because you were mentioned.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org