You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/06/26 23:55:48 UTC
Review Request 12123: WebUI fix: list all framework tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12123/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
WebUI fix: list all framework tasks.
Diffs
-----
src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
Diff: https://reviews.apache.org/r/12123/diff/
Testing
-------
Used in production at Airbnb.
Tested by using.
Thanks,
Brenden Matthews
Re: Review Request 12123: WebUI fix: list all framework tasks.
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12123/#review26999
-----------------------------------------------------------
I tried merging completed frameworks that were later re-registered with the same ID. I also merged all completed frameworks with the same ID to prevent losing task data: https://reviews.apache.org/r/14644/
- Ross Allen
On June 26, 2013, 9:55 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12123/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WebUI fix: list all framework tasks.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12123/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> Tested by using.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 12123: WebUI fix: list all framework tasks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12123/#review22676
-----------------------------------------------------------
Can you confirm this fixes MESOS-417? If so, great! And be sure to link the ticket in this review.
I wish there was a cleaner way to uniquely identify the framework "run" we care about. There are a few ways that we may want to consider in the long term if this continues to get messier. We could add a run identifier to framework information. Alternatively, we could merge the completedFramework information with the re-registration of the framework. Thoughts for later.
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/12123/#comment46357>
Can you adjust the comment to reflect the fact that we're merging the active and completed runs of the framework?
Note that the framework can only be present once in frameworks, but multiple times in completed_frameworks (depending on the number of failovers).
Also s/framework/frameworkRuns/ to be more clear.
- Ben Mahler
On June 26, 2013, 9:55 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12123/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WebUI fix: list all framework tasks.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12123/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> Tested by using.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 12123: WebUI fix: list all framework tasks.
Posted by Ben Mahler <be...@gmail.com>.
> On July 17, 2013, 5:45 p.m., Ross Allen wrote:
> > src/webui/master/static/controllers.js, line 581
> > <https://reviews.apache.org/r/12123/diff/1/?file=311293#file311293line581>
> >
> > The UI expects '$scope.framework' to be set so it can access 'framework.id', 'framework.name', and a few others.
> >
> > Can the completed frameworks be merged to create a reasonable state of this framework for the UI?
Yeah, I synced with benh on this one. We think a clean fix here is to remove the framework from 'completedFrameworks' when the framework re-registers. This change will need to happen in the Master.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12123/#review23308
-----------------------------------------------------------
On June 26, 2013, 9:55 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12123/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WebUI fix: list all framework tasks.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12123/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> Tested by using.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 12123: WebUI fix: list all framework tasks.
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12123/#review23308
-----------------------------------------------------------
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/12123/#comment47192>
The UI expects '$scope.framework' to be set so it can access 'framework.id', 'framework.name', and a few others.
Can the completed frameworks be merged to create a reasonable state of this framework for the UI?
- Ross Allen
On June 26, 2013, 9:55 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12123/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 9:55 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WebUI fix: list all framework tasks.
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd
>
> Diff: https://reviews.apache.org/r/12123/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> Tested by using.
>
>
> Thanks,
>
> Brenden Matthews
>
>