You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/10 02:34:21 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9278: MINOR: remove DelayedOperations.checkAndCompleteFetch
chia7712 opened a new pull request #9278:
URL: https://github.com/apache/kafka/pull/9278
inspired by https://github.com/apache/kafka/pull/8657#discussion_r484092945
```
With this change, DelayedOperations.checkAndCompleteFetch() is only used in tests. I am wondering if it can be removed. It's fine if we want to do this in a followup PR.
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9278: MINOR: remove DelayedOperations.checkAndCompleteFetch
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9278:
URL: https://github.com/apache/kafka/pull/9278#issuecomment-689937879
@junrao FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9278: MINOR: remove DelayedOperations.checkAndCompleteFetch
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9278:
URL: https://github.com/apache/kafka/pull/9278#discussion_r486027311
##########
File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala
##########
@@ -922,102 +918,6 @@ class PartitionTest extends AbstractPartitionTest {
assertEquals("ISR", Set[Integer](leader, follower1, follower2), partition.inSyncReplicaIds)
}
- /**
- * Verify that delayed fetch operations which are completed when records are appended don't result in deadlocks.
- * Delayed fetch operations acquire Partition leaderIsrUpdate read lock for one or more partitions. So they
- * need to be completed after releasing the lock acquired to append records. Otherwise, waiting writers
- * (e.g. to check if ISR needs to be shrinked) can trigger deadlock in request handler threads waiting for
- * read lock of one Partition while holding on to read lock of another Partition.
- */
- @Test
- def testDelayedFetchAfterAppendRecords(): Unit = {
Review comment:
```appendRecordsToLeader`` does not complete delayed fetch anymore (c2273adc25b2bab0a3ac95bf7844fedf2860b40b) so this test can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #9278: MINOR: remove DelayedOperations.checkAndCompleteFetch
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #9278:
URL: https://github.com/apache/kafka/pull/9278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org