[GitHub] DaanHoogland commented on a change in pull request #3151: api: rename ListUsageRecords file name to ListUsageRecordsCmd

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3151: api: rename ListUsageRecords file name to ListUsageRecordsCmd
URL: https://github.com/apache/cloudstack/pull/3151#discussion_r251411265
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListUsageRecordsCmd.java
 ##########
 @@ -38,10 +38,13 @@
 
 import com.cloud.utils.Pair;
 
-@APICommand(name = "listUsageRecords", description = "Lists usage records for accounts", responseObject = UsageRecordResponse.class,
-        requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
-public class GetUsageRecordsCmd extends BaseListCmd {
-    public static final Logger s_logger = Logger.getLogger(GetUsageRecordsCmd.class.getName());
+@APICommand(name = "listUsageRecords",
+        description = "Lists usage records for accounts",
+        responseObject = UsageRecordResponse.class,
+        requestHasSensitiveInfo = false,
+        responseHasSensitiveInfo = false)
+public class ListUsageRecordsCmd extends BaseListCmd {
+    public static final Logger s_logger = Logger.getLogger(ListUsageRecordsCmd.class.getName());
 
     private static final String s_name = "listusagerecordsresponse";
 
 Review comment:
   might as well cleanup this part as well, i.e. create the command APINAME instead and put/get the "response" bit in/from a separate field (see for instans ListAnnotationsCmd)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services