[GitHub] [incubator-doris] morningman commented on a change in pull request #6027: [Feature] Export data supports parquet format

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-doris/pull/6027#discussion_r659895133



##########
File path: gensrc/thrift/DataSinks.thrift
##########
@@ -114,7 +114,10 @@ struct TExportSink {
     4: required string line_delimiter
     // properties need to access broker.
     5: optional list<Types.TNetworkAddress> broker_addresses
-    6: optional map<string, string> properties;
+    6: optional map<string, string> properties
+    7: optional list<list<string>> schema
+    8: optional map<string, string> file_properties

Review comment:
       `file_properties` not used?

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##########
@@ -95,6 +95,7 @@
     public static final String KEY_IN_PARAM_LINE_DELIMITER = "line_delimiter";
     public static final String KEY_IN_PARAM_PARTITIONS = "partitions";
     public static final String KEY_IN_PARAM_FORMAT_TYPE = "format";
+    public static final String KEY_IN_PARAM_FILE_PROPERTIES = "file_properties";

Review comment:
       Seems useless?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org