You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/12 04:00:42 UTC
[GitHub] [arrow-rs] liukun4515 opened a new issue, #2702: Support bitwise op in arrow-rs
liukun4515 opened a new issue, #2702:
URL: https://github.com/apache/arrow-rs/issues/2702
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
from the issue about bitwise op in the datafusion, we should migration the bitwise op to the arrow-rs
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1250017693
> The issue you've linked relates to const versions of the functions, looking at the docs wrapping_shl seems to be defined for all the primitive types - e.g. https://doc.rust-lang.org/stable/std/primitive.i64.html#method.wrapping_shl
But the `rhs` type only be `u32` for any primitive typs.
My point is the api of https://doc.rust-lang.org/stable/src/core/num/wrapping.rs.html#87.
Do you means that we can implement all data type with converting the `rhs` value to the type of `u32`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1249168427
The issue you've linked relates to const versions of the functions, looking at the docs wrapping_shl seems to be defined for all the primitive types - e.g. https://doc.rust-lang.org/stable/std/primitive.i64.html#method.wrapping_shl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1243711661
I think moving these kernels to arrow is a great idea -- thank you @liukun4515 -- and likely the experts in arrow-rs will be able to offer some suggestions on how to improve the performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1250049151
> Tbh I'm not sure I fully understand the use-case for left or right shifting based on anything but a scalar, what does C++ do?
I think the biggest argument in my mind is for completeness -- I can cook up some examples when one might use it but they would definitely be contrived.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1250026893
Tbh I'm not sure I fully understand the use-case for left or right shifting based on anything but a scalar, what does C++ do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2702: [EPIC] Support bitwise op in arrow-rs
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #2702: [EPIC] Support bitwise op in arrow-rs
URL: https://github.com/apache/arrow-rs/issues/2702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1250049229
I don't have any thoughts or opinions on the shift implementation -- I defer to @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #2702: Support bitwise op in arrow-rs
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2702:
URL: https://github.com/apache/arrow-rs/issues/2702#issuecomment-1248819412
@alamb @tustvold
When I implement the left/right shift operation for the bitwise, I meet a issue.
In the rust, the operation` << or shl` will be overflow which don't like the ` bitand, bitor`.
The `warpping_shl` just support `wrapping_shl(self, u32) -> Self`, the `wrapping_shl` for generic type is feature in the rust https://github.com/rust-lang/rust/issues/90080
Do you have any thoughts about that?
Can we add a new trait like `ArrowNativeTypeOp` to support the `shl_wrapping(self, u32) -> Self`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org