You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/04/19 16:22:18 UTC
Review Request 58534: AMBARI-20784 Able to hide the "Why public repo
not
selected" when no stacks have repoinfo.xml with the "latest" section
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58534/
-----------------------------------------------------------
Review request for Ambari, Sangeeta Ravindran and Tim Thorpe.
Bugs: Ambari-20784
https://issues.apache.org/jira/browse/Ambari-20784
Repository: ambari
Description
-------
Able to hide the "Why public repo not selected" when no stacks have repoinfo.xml with the "latest" section. There is no point of display the error based on the stackDefault checking when no stacks even offer the "latest" section in their repoinfo.xml.
Diffs
-----
ambari-web/app/controllers/wizard/step1_controller.js 2ac295b
ambari-web/app/mappers/stack_mapper.js 4b6a6f8
ambari-web/app/models/stack.js dbc2d72
ambari-web/app/templates/wizard/step1.hbs 769aca3
ambari-web/app/utils/ajax/ajax.js 2d157fe
Diff: https://reviews.apache.org/r/58534/diff/1/
Testing
-------
existing unit tests
Build Ambari server and agent RPMs off trunk code with the changes, run install. Modify repoinfo.xml in 2.x and 3.0 stacks to remove <latest> section, verify the "Why not selected" is hidden. and when some stacks have the <latest> section, the link shows up if no stacks have repo with stackDefault=False.
Thanks,
Di Li