[GitHub] [arrow-datafusion] timvw commented on a diff in pull request #4126: Enable TableProviderFactories to receive additional options when creating an external table

[GitBox <gi...@apache.org>]

timvw commented on code in PR #4126:
URL: https://github.com/apache/arrow-datafusion/pull/4126#discussion_r1016162564


##########
datafusion/sql/src/parser.rs:
##########
@@ -627,6 +677,48 @@ mod tests {
             "CREATE EXTERNAL TABLE t(c1 int) STORED AS CSV PARTITIONED BY (p1 int) LOCATION 'foo.csv'";
         expect_parse_error(sql, "sql parser error: Expected ',' or ')' after partition definition, found: int");
 
+        // positive case: additional options (one entry) can be specified
+        let sql =
+            "CREATE EXTERNAL TABLE t STORED AS x OPTIONS ('k1' 'v1') LOCATION 'blahblah'";

Review Comment:
   That is what the code originally did. After [feedback](https://github.com/apache/arrow-datafusion/issues/4125#issuecomment-1305826215) from @avantgardnerio I changed to follow postgresql dialect (https://www.postgresql.org/docs/current/sql-createforeigntable.html)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org