You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/26 01:55:22 UTC
[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
zhuangchong opened a new issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568
**Describe the question**
When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists,
the system normally prompts workflow definition name validation error
**Which version of DolphinScheduler:**
-[1.3.4-release,dev]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs closed issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568#issuecomment-767970425
I think "workflow name already exists" is clearer, and I don't know where the error is when I prompt "workflow name verification error"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568#issuecomment-767990006
> ok, it's good
help review PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568#issuecomment-767983929
> I think "workflow name already exists" is clearer, and I don't know where the error is when I prompt "workflow name verification error"
I didn't express myself clearly. I'm going to change it this way
VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR state is used for prompt verifyProcessDefinitionName method throws an exception
```
@ApiException(VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR)
public Result verifyProcessDefinitionName(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectName", value = "PROJECT_NAME", required = true) @PathVariable String projectName,
@RequestParam(value = "name", required = true) String name) {
logger.info("verify process definition name unique, user:{}, project name:{}, process definition name:{}",
loginUser.getUserName(), projectName, name);
Map<String, Object> result = processDefinitionService.verifyProcessDefinitionName(loginUser, projectName, name);
return returnDataList(result);
}
```
PROCESS_DEFINITION_NAME_EXIST state is the prompt used to verify the existence of the workflow definition name
```
ProcessDefinition processDefinition = processDefineMapper.verifyByDefineName(project.getId(), name);
if (processDefinition == null) {
putMsg(result, Status.SUCCESS);
} else {
putMsg(result, Status.PROCESS_DEFINITION_NAME_EXIST, name);
}
```
I think the VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR and PROCESS_DEFINITION_NAME_EXIST states are both required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #4568: [Improvement][API] When the workflow definition name validation API fails, the system prompts that the workflow definition name already exists
Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #4568:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4568#issuecomment-767988896
ok, it's good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org