You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/01 16:36:05 UTC

[GitHub] [beam] miracvbasaran opened a new pull request #13865: [Go] Copy Annotations when cloning PTransforms

miracvbasaran opened a new pull request #13865:
URL: https://github.com/apache/beam/pull/13865


   We need to copy Annotations field as well when doing a ShallowClonePTransform, otherwise we lose the Annotations.
   
   CREDITS=robertre@


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck merged pull request #13865: [BEAM-11357] Copy Annotations when cloning PTransforms

Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #13865:
URL: https://github.com/apache/beam/pull/13865


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertre commented on pull request #13865: [Go] Copy Annotations when cloning PTransforms

Posted by GitBox <gi...@apache.org>.
robertre commented on pull request #13865:
URL: https://github.com/apache/beam/pull/13865#issuecomment-770990471


   LGTM. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #13865: [BEAM-11357] Copy Annotations when cloning PTransforms

Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #13865:
URL: https://github.com/apache/beam/pull/13865#issuecomment-771193658


   Note: you can get my attention easily with a comment saying
   
   R: @lostluck  
   Which pings me approprately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org