[jira] [Work logged] (GOBBLIN-1379) Distcp hides real exception when retry happen

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1379?focusedWorklogId=544618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544618 ]

ASF GitHub Bot logged work on GOBBLIN-1379:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jan/21 01:29
            Start Date: 30/Jan/21 01:29
    Worklog Time Spent: 10m 
      Work Description: aplex opened a new pull request #3219:
URL: https://github.com/apache/incubator-gobblin/pull/3219


   When folder creation fails in FileAwareInputStreamDataWriter with permission error,
   operation is retried. However, the original permission error was not logged or
   shown anywhere. Instead users saw a misleading error about incorrect writer state.
   
   Since errors can be different on each attempt, we're now logging all of them.
   
   In addition, writer logic is updated to handle retries correctly when error
   happens on the early stage.
   
   https://issues.apache.org/jira/browse/GOBBLIN-1379
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 544618)
    Remaining Estimate: 0h
            Time Spent: 10m

> Distcp hides real exception when retry happen
> ---------------------------------------------
>
>                 Key: GOBBLIN-1379
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1379
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-core
>            Reporter: Alex Prokofiev
>            Assignee: Abhishek Tiwari
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When folder creation fails in FileAwareInputStreamDataWriter with permission error , operation is retried. However, the original permission error is not logged or shown anywhere. Instead users see a misleading error about incorrect writer state.
> {code:java}
> 2021-01-14 20:04:21,173 ERROR [main] org.apache.gobblin.runtime.fork.Fork-0: Fork 0 of task task_HiveDistcpForDatabasesTier0_1610654490216_2004 failed to process data records. Set throwable in holder org.apache.gobblin.runtime.ForkThrowableHolder@567cfbdd
> java.io.IOException: com.github.rholder.retry.RetryException: Retrying failed to complete successfully after 5 attempts.
> at org.apache.gobblin.writer.RetryWriter.callWithRetry(RetryWriter.java:144)
> at org.apache.gobblin.writer.RetryWriter.writeEnvelope(RetryWriter.java:124)
> at org.apache.gobblin.runtime.fork.Fork.processRecord(Fork.java:520)
> at org.apache.gobblin.runtime.fork.AsynchronousFork.processRecord(AsynchronousFork.java:103)
> at org.apache.gobblin.runtime.fork.AsynchronousFork.processRecords(AsynchronousFork.java:86)
> at org.apache.gobblin.runtime.fork.Fork.run(Fork.java:250)
> at org.apache.gobblin.util.executors.MDCPropagatingRunnable.run(MDCPropagatingRunnable.java:39)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.github.rholder.retry.RetryException: Retrying failed to complete successfully after 5 attempts.
> at com.github.rholder.retry.Retryer.call(Retryer.java:174)
> at com.github.rholder.retry.Retryer$RetryerCallable.call(Retryer.java:318)
> at org.apache.gobblin.writer.RetryWriter.callWithRetry(RetryWriter.java:142)
> ... 11 more
> Caused by: java.io.IOException: org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter can only process one file.
> at org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter.writeImpl(FileAwareInputStreamDataWriter.java:199)
> at org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter.writeImpl(FileAwareInputStreamDataWriter.java:83)
> at org.apache.gobblin.instrumented.writer.InstrumentedDataWriterBase.write(InstrumentedDataWriterBase.java:158)
> at org.apache.gobblin.instrumented.writer.InstrumentedDataWriter.write(InstrumentedDataWriter.java:38)
> at org.apache.gobblin.writer.DataWriter.writeEnvelope(DataWriter.java:106)
> at org.apache.gobblin.writer.CloseOnFlushWriterWrapper.writeEnvelope(CloseOnFlushWriterWrapper.java:97)
> at org.apache.gobblin.instrumented.writer.InstrumentedDataWriterDecorator.writeEnvelope(InstrumentedDataWriterDecorator.java:76)
> at org.apache.gobblin.writer.PartitionedDataWriter.writeEnvelope(PartitionedDataWriter.java:239)
> at org.apache.gobblin.writer.RetryWriter$2.call(RetryWriter.java:119)
> at org.apache.gobblin.writer.RetryWriter$2.call(RetryWriter.java:116)
> at com.github.rholder.retry.AttemptTimeLimiters$NoAttemptTimeLimit.call(AttemptTimeLimiters.java:78)
> at com.github.rholder.retry.Retryer.call(Retryer.java:160)
> ... 13 more
> 2021-01-14 20:04:21,173 INFO [main] org.apache.gobblin.runtime.Task: Task shutdown: Fork future reaped in 15358 millis
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)