You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2023/04/02 04:00:14 UTC
[GitHub] [hudi] huangxiaopingRD opened a new pull request, #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
huangxiaopingRD opened a new pull request, #8355:
URL: https://github.com/apache/hudi/pull/8355
### Change Logs
If the database is not specified, `getHoodieCatalogTable` will default to look up the table in the `default` database, if it is not a table in the `default` database, it will appear
`Error in query: Table or view 'hudi_mor_tbl' not found in database 'default'
`
This PR is to support the creation of `HoodieClient` in the case of `non-default` database.
### Impact
no
### Risk level (write none, low medium or high below)
none
### Documentation Update
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1517073476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1519324054
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
}, {
"hash" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86db1f4f7be8f8b8dcd56e13bd945977fc804591 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549)
* 084ba2be0afd9343ae97d25e5d6edd2029b909fc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1501347516
@XuQianJin-Stars Can you help with a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518330336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172507129
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
Yes, let me remove the code about empty judgment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD closed pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD closed pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
URL: https://github.com/apache/hudi/pull/8355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172334280
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
Can the `databaseName` be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172059909
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
Judgment has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518511662
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548)
* 86db1f4f7be8f8b8dcd56e13bd945977fc804591 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1514906700
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61a2efa806a9004721966f885f84d95f1b882dbd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258)
* bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1517598120
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499)
* d99a80f1654e96f474fc2a047e38bf232a0bed81 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518501973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172753269
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
> It will not be null
It's not true for Flink, by default Flink sets null as the database name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1493223583
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1519298606
Can you rebase with latest master and force push again~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518651086
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86db1f4f7be8f8b8dcd56e13bd945977fc804591 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1519328391
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
}, {
"hash" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16590",
"triggerID" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86db1f4f7be8f8b8dcd56e13bd945977fc804591 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549)
* 084ba2be0afd9343ae97d25e5d6edd2029b909fc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16590)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518500145
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1519442821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16549",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
}, {
"hash" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16590",
"triggerID" : "084ba2be0afd9343ae97d25e5d6edd2029b909fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 084ba2be0afd9343ae97d25e5d6edd2029b909fc Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16590)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1493256287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172376778
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
It will not be null. Because when creating a hudi table, if there is no database, the current default database will be used as the databaseName. So `metaClient.getTableConfig.getDatabaseName` usually returns `default`.
We can see the part from here:
https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/catalyst/catalog/HoodieCatalogTable.scala#L187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172044384
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
Be caution that `metaClient.getTableConfig.getDatabaseName` does not have default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1523305496
> Can you rebase with the latest master and resolve the conflicts
I found this [PR](https://github.com/apache/hudi/pull/8488) had fixed the issue at yesterday. I will close this one. Thank you @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1515519301
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1493222731
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1515716287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464)
* 99df899b05de36a908a256758554ebde96d7a912 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1515710796
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464)
* 99df899b05de36a908a256758554ebde96d7a912 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1516305513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99df899b05de36a908a256758554ebde96d7a912 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479)
* d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1503354074
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063)
* 61a2efa806a9004721966f885f84d95f1b882dbd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1503368722
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063)
* 61a2efa806a9004721966f885f84d95f1b882dbd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1173578259
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1517607470
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499)
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1516077247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99df899b05de36a908a256758554ebde96d7a912 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518503545
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16499",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527",
"triggerID" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"triggerType" : "PUSH"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546",
"triggerID" : "1518494041",
"triggerType" : "MANUAL"
}, {
"hash" : "d99a80f1654e96f474fc2a047e38bf232a0bed81",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548",
"triggerID" : "1518501695",
"triggerType" : "MANUAL"
}, {
"hash" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86db1f4f7be8f8b8dcd56e13bd945977fc804591",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d99a80f1654e96f474fc2a047e38bf232a0bed81 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16527) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16546) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16548)
* 86db1f4f7be8f8b8dcd56e13bd945977fc804591 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518501695
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1503798063
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61a2efa806a9004721966f885f84d95f1b882dbd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1514892309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61a2efa806a9004721966f885f84d95f1b882dbd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258)
* bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1518494041
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8355:
URL: https://github.com/apache/hudi/pull/8355#discussion_r1172423380
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -40,8 +41,9 @@ object HoodieCLIUtils extends ProvidesHoodieConfig{
.setConf(sparkSession.sessionState.newHadoopConf()).build()
val schemaUtil = new TableSchemaResolver(metaClient)
val schemaStr = schemaUtil.getTableAvroSchema(false).toString
+ val table = StringUtils.join(metaClient.getTableConfig.getDatabaseName, ".", metaClient.getTableConfig.getTableName)
val finalParameters = HoodieWriterUtils.parametersWithWriteDefaults(
- buildHoodieConfig(getHoodieCatalogTable(sparkSession, metaClient.getTableConfig.getTableName)) ++ conf)
Review Comment:
So the database name can never be empty right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1516291461
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16063",
"triggerID" : "a00ea5107f04b2ad26ea37ae5a6e7b462b0aecbf",
"triggerType" : "PUSH"
}, {
"hash" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16258",
"triggerID" : "61a2efa806a9004721966f885f84d95f1b882dbd",
"triggerType" : "PUSH"
}, {
"hash" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16464",
"triggerID" : "bc165df2e2fcf0cbdb3646d35c3b0d5a2cdcc1ce",
"triggerType" : "PUSH"
}, {
"hash" : "99df899b05de36a908a256758554ebde96d7a912",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479",
"triggerID" : "99df899b05de36a908a256758554ebde96d7a912",
"triggerType" : "PUSH"
}, {
"hash" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99df899b05de36a908a256758554ebde96d7a912 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16479)
* d4a7a83f45a710a1e7ec6028e5b1c3d47d2bc83a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1519304518
> Can you rebase with latest master and force push again~
Done. Please approve the workflows. BTW, why ordinary contributors can't trigger the workflows? I remember it was possible before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8355: [HUDI-6016] HoodieCLIUtils supports creating HoodieClient with non-default database
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8355:
URL: https://github.com/apache/hudi/pull/8355#issuecomment-1522735498
Can you rebase with the latest master and resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org