You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jmjoy (via GitHub)" <gi...@apache.org> on 2023/11/08 04:01:53 UTC
[PR] Fix swoole server on request param. [skywalking-php]
jmjoy opened a new pull request, #100:
URL: https://github.com/apache/skywalking-php/pull/100
Fix https://github.com/apache/skywalking/issues/11488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix swoole server on request param. [skywalking-php]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #100:
URL: https://github.com/apache/skywalking-php/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix swoole server on request param. [skywalking-php]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #100:
URL: https://github.com/apache/skywalking-php/pull/100#discussion_r1385950298
##########
Cargo.toml:
##########
@@ -21,7 +21,7 @@ members = [
[package]
name = "skywalking-php"
-version = "0.7.0"
+version = "0.8.0-dev"
authors = ["Apache Software Foundation", "jmjoy <jm...@apache.org>", "Yanlong He <he...@apache.org>"]
description = "Apache SkyWalking PHP Agent."
edition = "2021"
Review Comment:
Do we need to update this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix swoole server on request param. [skywalking-php]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #100:
URL: https://github.com/apache/skywalking-php/pull/100#issuecomment-1801126842
Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix swoole server on request param. [skywalking-php]
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #100:
URL: https://github.com/apache/skywalking-php/pull/100#issuecomment-1801612272
> Please fix CI.
The vagrant of Mac in CI is crash, I will retry it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix swoole server on request param. [skywalking-php]
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on code in PR #100:
URL: https://github.com/apache/skywalking-php/pull/100#discussion_r1386016486
##########
Cargo.toml:
##########
@@ -21,7 +21,7 @@ members = [
[package]
name = "skywalking-php"
-version = "0.7.0"
+version = "0.8.0-dev"
authors = ["Apache Software Foundation", "jmjoy <jm...@apache.org>", "Yanlong He <he...@apache.org>"]
description = "Apache SkyWalking PHP Agent."
edition = "2021"
Review Comment:
Yes, we need to start a new version development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org