You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2016/01/04 02:26:58 UTC
Review Request 41866: SQOOP-2760: Sqoop2: Fix update command with
name for link and job
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41866/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
There has some problems when update the link/job if the name is changed.
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java f037399
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ab9c93b
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java b3262bd
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 810b913
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 7a9f1c6
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 82e29c5
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java efbd533
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java e1e23e2
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 7fa6a3b
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 5b1258f
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 0b6ff01
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java a72b6ad
shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 1056f12
Diff: https://reviews.apache.org/r/41866/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 41866: SQOOP-2760: Sqoop2: Fix update command with
name for link and job
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41866/#review112576
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Jan. 4, 2016, 5:49 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41866/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 5:49 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> There has some problems when update the link/job if the name is changed.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java f037399
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ab9c93b
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java b3262bd
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 810b913
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 7a9f1c6
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 82e29c5
> core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 0ffc645
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java efbd533
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java e1e23e2
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 7fa6a3b
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 5b1258f
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 0b6ff01
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java a72b6ad
> shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
> test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 1056f12
>
> Diff: https://reviews.apache.org/r/41866/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 41866: SQOOP-2760: Sqoop2: Fix update command with
name for link and job
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41866/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 5:49 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
There has some problems when update the link/job if the name is changed.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java f037399
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ab9c93b
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java b3262bd
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 810b913
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 7a9f1c6
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 82e29c5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 0ffc645
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java efbd533
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java e1e23e2
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 7fa6a3b
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 5b1258f
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 0b6ff01
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java a72b6ad
shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java 1056f12
Diff: https://reviews.apache.org/r/41866/diff/
Testing
-------
Thanks,
Colin Ma