You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/11/08 20:36:35 UTC

[PR] Backport Fix serialization of large integers (#5038) (#5042) to `48.0.0_maintenance` [arrow-rs]

alamb opened a new pull request, #5059:
URL: https://github.com/apache/arrow-rs/pull/5059

   # Which issue does this PR close?
   Related to https://github.com/apache/arrow-rs/issues/5050
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   Backports  #5042, the fix for #5038
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport: Fix serialization of large integers (#5038) (#5042) to `48.0.0_maintenance` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5059:
URL: https://github.com/apache/arrow-rs/pull/5059#issuecomment-1802736629

   Seems to be the same as https://github.com/apache/arrow-rs/pull/4957 -- I will also backport the CI fixes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport: Fix serialization of large integers (#5038) (#5042) to `48.0.0_maintenance` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5059:
URL: https://github.com/apache/arrow-rs/pull/5059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Backport: Fix serialization of large integers (#5038) (#5042) to `48.0.0_maintenance` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5059:
URL: https://github.com/apache/arrow-rs/pull/5059#issuecomment-1802733777

   The CI test seems to be failing due to something unrelated: https://github.com/apache/arrow-rs/actions/runs/6803782852/job/18499862891?pr=5059
   
   I will investigate more
   
   ```
   ##########################################################
   C Data Interface: C++ exporting, Java importing
   ##########################################################
       return _process_result(sub_ctx.command.invoke(sub_ctx))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
       return ctx.invoke(self.callback, **ctx.params)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 783, in invoke
       return __callback(*args, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/cli.py", line 787, in integration
       run_all_tests(**args)
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 638, in run_all_tests
       runner.run_c_data()
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 129, in run_c_data
       self._compare_c_data_implementations(producer, consumer)
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 425, in _compare_c_data_implementations
       with consumer.make_c_data_importer() as importer:
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/tester_java.py", line 349, in make_c_data_importer
       return JavaCDataImporter(self.debug, self.args)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/tester_java.py", line 89, in __init__
       import jpype
   ModuleNotFoundError: No module named 'jpype'
   ERROR conda.cli.main_run:execute(47): `conda run archery integration --run-flight --run-c-data --run-ipc --with-cpp=1 --with-csharp=1 --with-java=1 --with-js=1 --with-go=1 --with-rust=1 --gold-dirs=testing/data/arrow-ipc-stream/integration/0.14.1 --gold-dirs=testing/data/arrow-ipc-stream/integration/0.17.1 --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-bigendian --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-littleendian --gold-dirs=testing/data/arrow-ipc-stream/integration/2.0.0-compression --gold-dirs=testing/data/arrow-ipc-stream/integration/4.0.0-shareddict` failed. (See above for error)
   Error: Process completed with exit code 1.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org