You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2021/07/21 06:09:07 UTC

[shade] which java version

Hi all,

shade plugin pom defines java version to 7 (1.7) but it uses streams which
are java 8 only, should javaVersion property be updated?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>

Re: [shade] which java version

Posted by Romain Manni-Bucau <rm...@gmail.com>.
@Slawomir: It is mainly due to some dependencies like jdepndency which is
java 8 only so the plugin is overall java 8 now.

@Tibor: changing a 7 to a 8 in a pom, hope it does not take us a day ;)
If we say it is java 8, it will not change much but if we say it is java 7
we must revert a few things so hope we can just downgrade/revert some
dep/code, didn't check this option yet.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 21 juil. 2021 à 23:27, Tibor Digana <ti...@apache.org> a
écrit :

> What's the cost of this task? A day?
> Do you want to include it in the release version  3.4.0?
>
>
> On Wed, Jul 21, 2021 at 8:09 AM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > shade plugin pom defines java version to 7 (1.7) but it uses streams
> which
> > are java 8 only, should javaVersion property be updated?
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
>

Re: [shade] which java version

Posted by Tibor Digana <ti...@apache.org>.
What's the cost of this task? A day?
Do you want to include it in the release version  3.4.0?


On Wed, Jul 21, 2021 at 8:09 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:

> Hi all,
>
> shade plugin pom defines java version to 7 (1.7) but it uses streams which
> are java 8 only, should javaVersion property be updated?
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>

Re: [shade] which java version

Posted by Slawomir Jaranowski <s....@gmail.com>.
Hi,

very interesting case but I can't see 1.8 streams in
https://github.com/apache/maven-shade-plugin/tree/master

Can you point where you found it?

By the way, maybe it's time to start switching plugins to 1.8 ...


śr., 21 lip 2021 o 08:09 Romain Manni-Bucau <rm...@gmail.com>
napisał(a):

> Hi all,
>
> shade plugin pom defines java version to 7 (1.7) but it uses streams which
> are java 8 only, should javaVersion property be updated?
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>


-- 
Sławomir Jaranowski