You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "SkyTrix (via GitHub)" <gi...@apache.org> on 2024/01/03 13:50:42 UTC
[I] More descriptive failure messages in HttpMessageParser [incubator-pekko-http]
SkyTrix opened a new issue, #396:
URL: https://github.com/apache/incubator-pekko-http/issues/396
I'm currently investigating an issue where we're suddenly running into the following error: `HTTP chunk size exceeds the configured limit of 1048576 bytes`.
This is possibly due to an infrastructure change we made which results in a change of behavior when chunked transfer encoding is used. I did not find a way to determine the actual size of the incoming chunks and it would be really helpful if it was part of that error message.
My proposal here would be to extend all relevant errors in `HttpMessageParser` with extra parameter values. e.g. for the max chunk size, it looks very straightforward to add the `size` parameter to the error message:
https://github.com/apache/incubator-pekko-http/blob/4f80b1ef7cad2833382a659e7dd0b1a54078d126/http-core/src/main/scala/org/apache/pekko/http/impl/engine/parsing/HttpMessageParser.scala#L309-L320
Given that on line 318 the actual encountered illegal char is part of the error message, I think having the size in the other error is warranted. Apart from max chunk size there are a few other messages that could be improved such as max chunk extensions and amount of chunk trailer headers.
Any thoughts on this proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] More descriptive failure messages in HttpMessageParser [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #396: More descriptive failure messages in HttpMessageParser
URL: https://github.com/apache/pekko-http/issues/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] More descriptive failure messages in HttpMessageParser [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #396:
URL: https://github.com/apache/pekko-http/issues/396#issuecomment-2233007711
probably should have been closed after https://github.com/apache/pekko-http/pull/528 was merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org