You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sc...@apache.org on 2017/01/07 23:38:44 UTC
[3/4] maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly
suppresses exceptions when closing resources.
[SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.
o Updated various comments.
Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/8004064b
Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/8004064b
Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/8004064b
Branch: refs/heads/master
Commit: 8004064be0f1e40539cd7879aa7752a78af97891
Parents: 6745654
Author: Christian Schulte <sc...@apache.org>
Authored: Sun Jan 8 00:33:35 2017 +0100
Committer: Christian Schulte <sc...@apache.org>
Committed: Sun Jan 8 00:33:35 2017 +0100
----------------------------------------------------------------------
.../java/org/apache/maven/plugin/surefire/SurefireProperties.java | 2 +-
.../org/apache/maven/surefire/booter/SystemPropertyManager.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/8004064b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
----------------------------------------------------------------------
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
index b645032..0125aa4 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
@@ -247,7 +247,7 @@ public class SurefireProperties
}
catch ( final IOException e )
{
- // Suppressed.
+ // Suppressed, so that the exception thrown in the try block will be propagated.
}
}
}
http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/8004064b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
----------------------------------------------------------------------
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
index 68d79a4..8d301dc 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemPropertyManager.java
@@ -71,7 +71,7 @@ public class SystemPropertyManager
}
catch ( final IOException e1 )
{
- // Suppressed.
+ // Suppressed, so that the exception thrown in the try block will be propagated.
}
}
}