You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/12/20 17:02:13 UTC

Review Request 16424: some net util for dealing with isolation ids

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16424/
-----------------------------------------------------------

Review request for cloudstack, bharat kumar, Chiradeep Vittal, and Sheng Yang.


Repository: cloudstack-git


Description
-------

dealing with identifying vlans and other isolation networks.
vlan numbers now limited to 1-4094 according to spec (was 0-4096)


Diffs
-----

  utils/src/com/cloud/utils/net/NetUtils.java f6f6285 

Diff: https://reviews.apache.org/r/16424/diff/


Testing
-------


Thanks,

daan Hoogland


Re: Review Request 16424: some net util for dealing with isolation ids

Posted by daan Hoogland <da...@gmail.com>.

> On Dec. 23, 2013, 1:10 p.m., daan Hoogland wrote:
> > added as 94abbb1367bc817bae98f369e78679f0ddb7727f to 4.3 (not in master yet)

Commit 04570eefed9a0ee1eca1fd700ed5732ba67150ce in master


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16424/#review30821
-----------------------------------------------------------


On Dec. 20, 2013, 4:41 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16424/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 4:41 p.m.)
> 
> 
> Review request for cloudstack, bharat kumar, Chiradeep Vittal, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealing with identifying vlans and other isolation networks.
> vlan numbers now limited to 1-4094 according to spec (was 0-4096)
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/net/NetUtils.java f6f6285 
> 
> Diff: https://reviews.apache.org/r/16424/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Re: Review Request 16424: some net util for dealing with isolation ids

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16424/#review30821
-----------------------------------------------------------


added as 94abbb1367bc817bae98f369e78679f0ddb7727f to 4.3 (not in master yet)

- daan Hoogland


On Dec. 20, 2013, 4:41 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16424/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 4:41 p.m.)
> 
> 
> Review request for cloudstack, bharat kumar, Chiradeep Vittal, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> dealing with identifying vlans and other isolation networks.
> vlan numbers now limited to 1-4094 according to spec (was 0-4096)
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/net/NetUtils.java f6f6285 
> 
> Diff: https://reviews.apache.org/r/16424/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Re: Review Request 16424: some net util for dealing with isolation ids

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16424/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 4:41 p.m.)


Review request for cloudstack, bharat kumar, Chiradeep Vittal, and Sheng Yang.


Changes
-------

moved some statics up a bit


Repository: cloudstack-git


Description
-------

dealing with identifying vlans and other isolation networks.
vlan numbers now limited to 1-4094 according to spec (was 0-4096)


Diffs (updated)
-----

  utils/src/com/cloud/utils/net/NetUtils.java f6f6285 

Diff: https://reviews.apache.org/r/16424/diff/


Testing
-------


Thanks,

daan Hoogland