You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/07/12 12:56:48 UTC
Review Request 12504: CLOUDSTACK-2757. Category not persisted when config
items are added
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-2757
Repository: cloudstack-git
Description
-------
Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
Also cleaned up the code to use VO/DAO instead of SQL.
Diffs
-----
engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
Diff: https://reviews.apache.org/r/12504/diff/
Testing
-------
Thanks,
Likitha Shetty
Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when
config items are added
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23082
-----------------------------------------------------------
Commit 6e160d33361e2664f261fdc17d63e947b56105fe in branch refs/heads/master-6-17-stable from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6e160d3 ]
CLOUDSTACK-2757. When configs are added the value of the property 'category' is not persisted.
- ASF Subversion and Git Services
On July 12, 2013, 10:56 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-2757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
> Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
> Also cleaned up the code to use VO/DAO instead of SQL.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
>
> Diff: https://reviews.apache.org/r/12504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when
config items are added
Posted by Likitha Shetty <li...@citrix.com>.
> On July 12, 2013, 11:08 a.m., Kishan Kavala wrote:
> > Looks good to me
Thanks for reviewing Kishan.
- Likitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23078
-----------------------------------------------------------
On July 12, 2013, 10:56 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-2757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
> Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
> Also cleaned up the code to use VO/DAO instead of SQL.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
>
> Diff: https://reviews.apache.org/r/12504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when
config items are added
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23078
-----------------------------------------------------------
Ship it!
Looks good to me
- Kishan Kavala
On July 12, 2013, 4:26 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 4:26 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-2757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
> Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
> Also cleaned up the code to use VO/DAO instead of SQL.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
>
> Diff: https://reviews.apache.org/r/12504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when
config items are added
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23080
-----------------------------------------------------------
Commit 87df51356b8d3a00c1c7a8def753de052a471b3e in branch refs/heads/4.2 from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=87df513 ]
CLOUDSTACK-2757. When configs are added the value of the property 'category' is not persisted.
- ASF Subversion and Git Services
On July 12, 2013, 10:56 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-2757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
> Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
> Also cleaned up the code to use VO/DAO instead of SQL.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
>
> Diff: https://reviews.apache.org/r/12504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 12504: CLOUDSTACK-2757. Category not persisted when
config items are added
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12504/#review23081
-----------------------------------------------------------
Commit aaaf168f5a38294ef098bdf9c60657711f6655bf in branch refs/heads/master from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aaaf168 ]
CLOUDSTACK-2757. When configs are added the value of the property 'category' is not persisted.
- ASF Subversion and Git Services
On July 12, 2013, 10:56 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12504/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-2757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Category is not being persisted when configuration items are added in ConfigurationDaoImpl.getValueAndInitIfNotExist.
> Hence it will be set to 'Advanced' which is the default which will lead to encryption failures if encryption is enabled.
> Also cleaned up the code to use VO/DAO instead of SQL.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java fe5f5ae
>
> Diff: https://reviews.apache.org/r/12504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Likitha Shetty
>
>