[GitHub] [superset] villebro commented on a change in pull request #12483: fix(dashboard): use datasource id from slice metadata

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #12483:
URL: https://github.com/apache/superset/pull/12483#discussion_r556664909



##########
File path: superset/charts/commands/importers/v1/__init__.py
##########
@@ -69,26 +70,29 @@ def _import(
                 database_ids[str(database.uuid)] = database.id
 
         # import datasets with the correct parent ref
-        dataset_info: Dict[str, Dict[str, Any]] = {}
+        datasets: Dict[str, SqlaTable] = {}

Review comment:
       While this is nowadays practically always `SqlaTable`, strictly speaking I think this should be `BaseDatasource`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org