You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 07:18:32 UTC

[GitHub] [arrow] AlenkaF opened a new pull request, #14642: ARROW-18322: [Python] source installation from pip without flight

AlenkaF opened a new pull request, #14642:
URL: https://github.com/apache/arrow/pull/14642

This PR adds the use of `PYARROW_WITH_FLIGHT` environment variable when building PyArrow C++. With this change PyArrow will be able to build successfully even when Arrow C++ is installed without Arrow Flight ([example](https://github.com/OSGeo/gdal/blob/58ab718542a7b5ceb94e3f24a5acc0b18ac1efb2/docker/ubuntu-full/Dockerfile#L223-L231), JFrog artifactory) but `ARROW_FLIGHT` flag is not registered to be set to off.
Note: `PYARROW_WITH_FLIGHT=0` is needed when building PyArrow.

I tested the change on my regular build with Arrow Flight but with removed `libarrow_flight*` libs. Without this patch I get:
```
CMake Error at /Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightTargets.cmake:93 (message):
The imported target "ArrowFlight::arrow_flight_shared" references the file

"/Users/alenkafrim/repos/arrow/dist/lib/libarrow_flight.1100.0.0.dylib"

but this file does not exist. Possible reasons include:

* The file was deleted, renamed, or moved to another location.

* An install or uninstall procedure did not complete successfully.

* The installation package was faulty and contained

"/Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightTargets.cmake"

but not all the files it references.

Call Stack (most recent call first):
/Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightConfig.cmake:56 (include)
CMakeLists.txt:262 (find_package)
```

With this patch PyArrow builds succesfully.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou merged pull request #14642: ARROW-18322: [Python] Add PYARROW_WITH_FLIGHT to PyArrow C++ cmake

Posted by GitBox <gi...@apache.org>.

kou merged PR #14642:
URL: https://github.com/apache/arrow/pull/14642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #14642: ARROW-18322: [Python] Add PYARROW_WITH_FLIGHT to PyArrow C++ cmake

Posted by GitBox <gi...@apache.org>.

ursabot commented on PR #14642:
URL: https://github.com/apache/arrow/pull/14642#issuecomment-1316697875

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/28def670a9b94c63aadcff87b2008631...f560bec7431d49bab44aaae31e785f18/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #14642: ARROW-18322: [Python] source installation from pip without flight

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #14642:
URL: https://github.com/apache/arrow/pull/14642#issuecomment-1314880408

   https://issues.apache.org/jira/browse/ARROW-18322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #14642: ARROW-18322: [Python] Add PYARROW_WITH_FLIGHT to PyArrow C++ cmake

Posted by GitBox <gi...@apache.org>.

ursabot commented on PR #14642:
URL: https://github.com/apache/arrow/pull/14642#issuecomment-1316697387

   Benchmark runs are scheduled for baseline = 77f099fb5c324afc8ee38cda4976bf20a08e7a4a and contender = 8f43a9fce9413a4e47077aef786990a1ec886d5b. 8f43a9fce9413a4e47077aef786990a1ec886d5b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/cc41b54ec35049e980fb2c834235c91f...e427ca9f55b14c3695df0348b7d119ad/)
   [Finished :arrow_down:0.6% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/36c643b05ab04297bf676277e8b8b235...a592dfceb7c74f908e9cb436609a5887/)
   [Finished :arrow_down:0.82% :arrow_up:0.82%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/28def670a9b94c63aadcff87b2008631...f560bec7431d49bab44aaae31e785f18/)
   [Finished :arrow_down:1.5% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ded9a114c61647a39981af5981b57d7e...d17813fda2ae4eaf804f91bc16f5a2cf/)
   Buildkite builds:
   [Finished] [`8f43a9fc` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1873)
   [Finished] [`8f43a9fc` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1895)
   [Finished] [`8f43a9fc` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1863)
   [Finished] [`8f43a9fc` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1887)
   [Finished] [`77f099fb` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1872)
   [Finished] [`77f099fb` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1894)
   [Finished] [`77f099fb` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1862)
   [Finished] [`77f099fb` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1886)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org