[jira] Commented: (PIG-1738) New logical plan: Optimized UserFuncExpression.getFieldSchema

["Yan Zhou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933524#action_12933524 ] 

Yan Zhou commented on PIG-1738:
-------------------------------

+1. This solution is to use caching of the often-used object. It is based on the assumption that once mFuncSpec is set, itself and its contents won't be modified, at least after the getFieldSchema method is called. But this invariant is nowhere to find in code. We may need to comment somehow. Otherwise patch looks ok.



> New logical plan: Optimized UserFuncExpression.getFieldSchema
> -------------------------------------------------------------
>
>                 Key: PIG-1738
>                 URL: https://issues.apache.org/jira/browse/PIG-1738
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1738-1.patch
>
>
> Currently every time we invoke UserFuncExpression.getFieldSchema, Pig will instantiate UserFunc. This is not efficient and should change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.