[GitHub] [tomcat] bokken commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

[GitBox <gi...@apache.org>]

bokken commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307798580
 
 

 ##########
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##########
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, Attributes attributes)
             if ("".equals(name)) {
                 name = attributes.getQName(i);
             }
-            String value = attributes.getValue(i);
+            String value = attributes.getValue(i).intern();
 
 Review comment:
   So Aleksey's article was used to determine that de-dup could help and then implemented it in the exact way that Aleksey proved was terrible?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org