You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Lorin Beer (JIRA)" <ji...@apache.org> on 2014/08/22 01:50:11 UTC
[jira] [Resolved] (CB-7355) [CLI] removing unit tests which depend
on external libraries
[ https://issues.apache.org/jira/browse/CB-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lorin Beer resolved CB-7355.
----------------------------
Resolution: Fixed
tests still need additional tweaking, but removed create tests which depended behaviour of external libs
> [CLI] removing unit tests which depend on external libraries
> ------------------------------------------------------------
>
> Key: CB-7355
> URL: https://issues.apache.org/jira/browse/CB-7355
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Lorin Beer
> Assignee: Lorin Beer
>
> The cordova-cli has vestigial unit tests which now trigger on external dependencies (example below)
> These should be removed from the cli, and migrated to the appropriate lib if necessary.
> {code}
> - it("will NOT allow copy-from starting with 'http'", function () {
> - var threwAnException = false;
> - try {
> - cli(["node", "cordova", "create", "a", "b" , "c", "--copy-from", "http://www.somesite.com"]);
> - }
> - catch(e) {
> - threwAnException = true;
> - }
> - expect(cordova_lib.CordovaError).toHaveBeenCalledWith('Only local paths for custom www assets are supported.');
> - expect(threwAnException).toBe(true);
> - });
> -
> - it("will allow link-to with ':' char", function () {
> {code}
> in the example above, the behaviour is not implemented within the cordova cli
--
This message was sent by Atlassian JIRA
(v6.2#6252)