You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/17 23:19:11 UTC

[GitHub] [airflow] busunkim96 opened a new pull request #17671: Allow google-auth < 3

busunkim96 opened a new pull request #17671:
URL: https://github.com/apache/airflow/pull/17671

`google-auth` recently published a 2.0.0 release which removed support for Python 2.7. `google-auth` now requires Python >=3.6. No other breaking changes were made. You can see the full list of changes [here](https://github.com/googleapis/google-auth-library-python/commit/560cf1ed02a900436c5d9e0a0fb3f94b5fd98c55).

I am opening PRs to expand google-auth version ranges for packages that meet either of the following criteria:
* Package has >10,000 monthly downloads as of June 2021
* Package is owned by a Google team

`google-auth` is a dependency of many different libraries that interact with Google APIs. Increasing the time and number of packages with compatible pins on `google-auth` lowers the chance end developers who use multiple libraries will see dependency conflicts.

If possible, please do not require `google-auth>=2.0.0` until https://github.com/googleapis/google-cloud-python/issues/10566 is resolved, as that will further reduce the likelihood of diamond dependency conflicts.

Googlers, see [this doc](https://docs.google.com/document/d/1euAvUsia_4zf98lNvpwA3K0o2b4y5Xr9xAkyzCnIMzQ/edit) for more information.

Given the number of google-cloud-* packages this library pins directly I think it may make more sense to expand pins on `google-api-core` and `google-auth` in one PR. (I've left this PR as a draft as the google-api-core release is planned for tomorrow, August 18).

**Constraints files**: I looked at https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pinned-constraint-files but am not quite sure what that means for this change.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

uranusjr commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r690920880



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       (Not directly related to this PR) @potiuk Why was the `dev` suffix added in the first place and can we remove it? This seems to be the only place we are specifying prereleases explicitly (in cdb3f25456e49d0199cd7ccd680626dac01c9be6).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #17671: Allow google-auth < 3 and google-api-core < 3

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #17671:
URL: https://github.com/apache/airflow/pull/17671


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#issuecomment-900694234

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] busunkim96 commented on a change in pull request #17671: Allow google-auth < 3 and google-api-core < 3

Posted by GitBox <gi...@apache.org>.

busunkim96 commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r692297581



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

uranusjr commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r691180048



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       @busunkim96 Could you try removing `dev` from the version constraints?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17671: Allow google-auth < 3 and google-api-core < 3

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#issuecomment-907444179


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

uranusjr commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r690920880



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       (Not directly related to this PR) @potiuk Why was the `dev` suffix added in the first place and can we remove it? This seems to be the only place we are specifying prereleases explicitly (in cdb3f25456e49d0199cd7ccd680626dac01c9be6).

##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       @busunkim96 Could you try removing `dev` from the version constraints?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17671: Allow google-auth < 3 and google-api-core < 3

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#issuecomment-907447901


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#issuecomment-900694234

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r691060083



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       Good point. I have no idea :). I added it > year ago, and without suitable comment (my bad). But I am quite sure, whatever it was then it is not applicable any more and we can change it to <3.0.0 - providing that it passes all the tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #17671: Allow google-auth < 3

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #17671:
URL: https://github.com/apache/airflow/pull/17671#discussion_r691060083



##########
File path: setup.py
##########
@@ -319,7 +319,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
     'pandas-gbq<0.15.0',
 ]
 grpc = [
-    'google-auth>=1.0.0, <2.0.0dev',
+    'google-auth>=1.0.0, <3.0.0dev',

Review comment:
       Good point. I have no idea :). I added it > year ago, and without suitable comment (my bad). But I am quite sure, whatever it was then it is not applicable any more and we can change it to <3.0.0 - providing that it passes all the tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org