You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/08/08 15:33:26 UTC

Review Request 24503: Flume: FLUME_HANDLER should have cardinality of 1+

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24503/
-----------------------------------------------------------

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-6791
    https://issues.apache.org/jira/browse/AMBARI-6791


Repository: ambari


Description
-------

Cardinality should require at least one handler when selecting flume.  This will also make sure that service checks can be run for the service without any special UI logic.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml d3e489e 

Diff: https://reviews.apache.org/r/24503/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:57.436s
[INFO] Finished at: Fri Aug 08 09:28:58 EDT 2014
[INFO] Final Memory: 22M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 24503: Flume: FLUME_HANDLER should have cardinality of 1+

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24503/#review50045
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Aug. 8, 2014, 10:57 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24503/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 10:57 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-6791
>     https://issues.apache.org/jira/browse/AMBARI-6791
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cardinality should require at least one handler when selecting flume.  This will also make sure that service checks can be run for the service without any special UI logic.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml d3e489e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 d4ded14 
> 
> Diff: https://reviews.apache.org/r/24503/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:57.436s
> [INFO] Finished at: Fri Aug 08 09:28:58 EDT 2014
> [INFO] Final Memory: 22M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 24503: Flume: FLUME_HANDLER should have cardinality of 1+

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24503/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 10:57 a.m.)


Review request for Ambari and Jonathan Hurley.


Changes
-------

Also added a bug found that resulted in minimum values being zero, and other values being coerced into long instead of doubles like the rest of them


Bugs: AMBARI-6791
    https://issues.apache.org/jira/browse/AMBARI-6791


Repository: ambari


Description
-------

Cardinality should require at least one handler when selecting flume.  This will also make sure that service checks can be run for the service without any special UI logic.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml d3e489e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/rrd.py.j2 d4ded14 

Diff: https://reviews.apache.org/r/24503/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:57.436s
[INFO] Finished at: Fri Aug 08 09:28:58 EDT 2014
[INFO] Final Memory: 22M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole