You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/15 17:57:08 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1050: feat: support to use jemalloc while building pegasus
empiredan opened a new pull request, #1050:
URL: https://github.com/apache/incubator-pegasus/pull/1050
This PR is for https://github.com/apache/incubator-pegasus/issues/819.
Previously we've supported jemalloc while building rDSN (https://github.com/XiaoMi/rdsn/pull/910). Since `dsn_common_setup()` are called in `src/CMakeLists.txt` before building executables, using jemalloc for pegasus can be supported by passing the option `USE_JEMALLOC` to `rdsn/bin/dsn.cmake`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan closed pull request #1050: feat: support to use jemalloc while building pegasus
Posted by GitBox <gi...@apache.org>.
empiredan closed pull request #1050: feat: support to use jemalloc while building pegasus
URL: https://github.com/apache/incubator-pegasus/pull/1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on pull request #1050: feat: support to use jemalloc while building pegasus
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on PR #1050:
URL: https://github.com/apache/incubator-pegasus/pull/1050#issuecomment-1186072733
Great！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1050: feat: support to use jemalloc while building pegasus
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1050:
URL: https://github.com/apache/incubator-pegasus/pull/1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1050: feat: support to use jemalloc while building pegasus
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1050:
URL: https://github.com/apache/incubator-pegasus/pull/1050#discussion_r923152269
##########
src/CMakeLists.txt:
##########
@@ -25,6 +25,11 @@ endif()
dsn_common_setup()
+message(STATUS "USE_JEMALLOC = ${USE_JEMALLOC}")
+if(USE_JEMALLOC)
+ message(STATUS "jemalloc is enabled")
+endif()
+
Review Comment:
Move to ./CMakeLists.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org