You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dmitry Zhuk <dz...@twopensource.com> on 2017/11/07 16:52:09 UTC
Review Request 63637: Added callable once support in defer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63637/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Michael Park.
Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972
Repository: mesos
Description
-------
This allows `defer` result to be converted to `CallableOnce`, ensuring
that bound arguments are moved, when call is made, and avoiding making
copies of bound arguments.
Diffs
-----
3rdparty/libprocess/include/process/deferred.hpp af65eadee6f29a5bcd29b5c8ccf7444f39f8899a
3rdparty/libprocess/src/tests/process_tests.cpp 952c92c033e2363cff0c2c68610d3820b97d177e
Diff: https://reviews.apache.org/r/63637/diff/1/
Testing
-------
make check
Thanks,
Dmitry Zhuk
Re: Review Request 63637: Added callable once support in defer.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63637/#review192915
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 4:20 a.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63637/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 4:20 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Bugs: MESOS-6972
> https://issues.apache.org/jira/browse/MESOS-6972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows `defer` result to be converted to `CallableOnce`, ensuring
> that bound arguments are moved, when call is made, and avoiding making
> copies of bound arguments.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/deferred.hpp 950f1cccaf93298664a95ba1fd2c5d2a42deb725
> 3rdparty/libprocess/src/tests/process_tests.cpp d1b30b0754c55fd765885ddcfe9f9f68ba509ac1
>
>
> Diff: https://reviews.apache.org/r/63637/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>
Re: Review Request 63637: Added callable once support in defer.
Posted by Dmitry Zhuk <dz...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63637/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 12:20 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Changes
-------
Removed use of `lambda::Placeholder`.
Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972
Repository: mesos
Description
-------
This allows `defer` result to be converted to `CallableOnce`, ensuring
that bound arguments are moved, when call is made, and avoiding making
copies of bound arguments.
Diffs (updated)
-----
3rdparty/libprocess/include/process/deferred.hpp 950f1cccaf93298664a95ba1fd2c5d2a42deb725
3rdparty/libprocess/src/tests/process_tests.cpp d1b30b0754c55fd765885ddcfe9f9f68ba509ac1
Diff: https://reviews.apache.org/r/63637/diff/4/
Changes: https://reviews.apache.org/r/63637/diff/3-4/
Testing
-------
make check
Thanks,
Dmitry Zhuk