[jira] [Comment Edited] (MYFACES-3965) SKIP_ITERATION visit hint not set when component tree is visited during navigation

["Leon Steffens (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366169#comment-14366169 ] 

Leon Steffens edited comment on MYFACES-3965 at 3/17/15 9:55 PM:
-----------------------------------------------------------------

Proposed fix is attached.


was (Author: leonsteffens):
Proposed fix.

> SKIP_ITERATION visit hint not set when component tree is visited during navigation
> ----------------------------------------------------------------------------------
>
>                 Key: MYFACES-3965
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3965
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.17
>            Reporter: Leon Steffens
>         Attachments: myfaces-navimpl.diff
>
>
> During navigation, the component tree is visited to publish the PreDestroyView event to all components in the tree ( org.apache.myfaces.application.NavigationHandlerImpl.handleNavigation).
> When the VisitContext is created, the SKIP_ITERATION VisitHint is not set in the VisitContext.  The only thing that is set is the SKIP_ITERATION attribute in the FacesContext attribute map, which is not honoured by libraries such as ICEfaces.
> This can cause an issue if rows in tables are visited and these rows have EL expressions that access backing beans that, for some or other reason, is no longer available.  In our case we switch between different contexts in our application before performing the navigation and the EL expression is evaluated against the new context instead of the old context, causing issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)