You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/07/01 14:59:20 UTC

[GitHub] flink pull request #2190: [FLINK-4141] remove leaderUpdated() method from Re...

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2190

    [FLINK-4141] remove leaderUpdated() method from ResourceManager

    This removes the leaderUpdated method from the framework. Further it
    lets the RM client thread communicate directly with the
    ResourceManager actor. This is fine since the two are always spawned
    together. Failures of the ResourceManager actor will lead to dropped
    messages of the RM client thread. Failures of the RM client thread will
    inform the JobManager.
    
    The leaderUpdated() method was used to signal the ResourceManager
    framework that a new leader was elected. However, the method was not
    always called when the leader changed, only when a new leader was
    elected. This dropped all messages from the async Yarn RM client
    thread (YarnResourceManagerCallbackHandler) for the time that the old
    leader had failed and no new leader had been elected. The Yarn RM client
    thread used leader tagged messages to communicate with the main Flink
    ResourceManager actor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-4141

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2190
    
----
commit c758121b9e5e2d7de8318bd529aa5da88ed424c6
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-07-01T14:27:18Z

    [FLINK-4141] remove leaderUpdated() method from ResourceManager
    
    This removes the leaderUpdated method from the framework. Further it
    lets the RM client thread communicate directly with the
    ResourceManager actor. This is fine since the two are always spawned
    together. Failures of the ResourceManager actor will lead to dropped
    messages of the RM client thread. Failures of the RM client thread will
    inform the JobManager.
    
    The leaderUpdated() method was used to signal the ResourceManager
    framework that a new leader was elected. However, the method was not
    always called when the leader changed, only when a new leader was
    elected. This dropped all messages from the async Yarn RM client
    thread (YarnResourceManagerCallbackHandler) for the time that the old
    leader had failed and no new leader had been elected. The Yarn RM client
    thread used leader tagged messages to communicate with the main Flink
    ResourceManager actor.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2190: [FLINK-4141] remove leaderUpdated() method from Re...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2190


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---