You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 12:56:13 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #216: update arrow-rs deps to latest master
alamb opened a new pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216
Update to the latest arrow-rs master. I did this with a script (PR coming shortly)
# Rationale for this change
Get the latest and greatest Arrow
# What changes are included in this PR?
Update to latest arrow + code changes needed to compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-828630956
@alamb I agree that we want frequent releases. I have not had much time to think about what we do next. We should collaborate on a process in the google doc we have going for the migration as next step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-828451896
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#216](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (80ac2e9) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/33715747db5a3cc48936c7b26859d4ad5809cde8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3371574) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 80ac2e9 differs from pull request most recent head 8fc1889. Consider uploading reports for the commit 8fc1889 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 76.39% 76.39%
=======================================
Files 134 134
Lines 23206 23206
=======================================
Hits 17728 17728
Misses 5478 5478
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3371574...8fc1889](https://codecov.io/gh/apache/arrow-datafusion/pull/216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-829114597
> We should collaborate on a process in the google doc we have going for the migration as next step?
I agree @andygrove if you haven't had a chance, when I next get some time I will make a doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-828588118
Looks good 💯. I am wondering what the process for doing releases to crates.io is going to be? In that case we need to use release versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-829114597
> We should collaborate on a process in the google doc we have going for the migration as next step?
I agree @andygrove if you haven't had a chance, when I next get some time I will do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#discussion_r622264279
##########
File path: dev/update_arrow_deps.py
##########
@@ -0,0 +1,83 @@
+#!/usr/bin/env python
Review comment:
I am sorry if this causes 👁️ 🩸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #216: update arrow-rs deps to latest master
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #216:
URL: https://github.com/apache/arrow-datafusion/pull/216#issuecomment-828599334
@Dandandan -- I would like to get to the point where we do much more frequent arrow releases (like maybe weekly) and then datafusion will just pick them up automatically
I was imagining, for example, releasing `4.1.0` shortly with these fixes.
But I don't really have a plan / sorted out a process for doing this yet -- @andygrove have you given the matter much thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org