[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1722: Dev 1.1.1 linkis-cli

[GitBox <gi...@apache.org>]

peacewong commented on a change in pull request #1722:
URL: https://github.com/apache/incubator-linkis/pull/1722#discussion_r825783499



##########
File path: linkis-computation-governance/linkis-client/linkis-cli/linkis-cli-application/src/main/java/org/apache/linkis/cli/application/constants/AppKeys.java
##########
@@ -17,11 +17,10 @@
 
 package org.apache.linkis.cli.application.constants;
 
-/** @description: Keys used by client. Usually in the form of prefix + LinkisKey */
-public class LinkisClientKeys {
+public class AppKeys {
 
     /** User Not configurable */
-    public static final String ADMIN_USERS = "hadoop,root";
+    public static final String ADMIN_USERS = "hadoop,root,shangda";

Review comment:
       need remove

##########
File path: linkis-computation-governance/linkis-client/linkis-cli/linkis-cli-application/src/main/assembly/distribution.xml
##########
@@ -40,46 +40,6 @@
                 <exclude>org.apache.spark:*:jar</exclude>
                 <exclude>org.apache.zookeeper:*:jar</exclude>
                 <exclude>org.apache.avro:*:jar</exclude>

Review comment:
       exclude should not be deleted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org