[GitHub] [flink] 1u0 commented on issue #9065: [FLINK-13102][travis] Optimize some travis stages by skipping mvn verify if possible

[GitBox <gi...@apache.org>]

1u0 commented on issue #9065: [FLINK-13102][travis] Optimize some travis stages by skipping mvn verify if possible
URL: https://github.com/apache/flink/pull/9065#issuecomment-509997347
 
 
   CC: @zentol 
   
   Some notes:
   
   With this PR, there is a code duplication in `tools/travis/stage.sh` and `tools/travis/stages.py` (they both have mapping which maven modules to build for a given stage). I want to remove it (my personal preference keeping python version), but would like to check first if python is fine for others.
   
   The dependencies detection heuristic relies on that inner module (artifacts) dependencies in Flink are explicit (declared in `pom.xml` files).
   The dependencies check can be further improved by taking into account maven test and non-test dependencies. But for now, the implementation in favor of simplicity and to avoid false skippings (it's ok if we run tests, even if changes are not relevant; it's not ok, if we don't run tests, if changes are relevant and detection missed it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services